summaryrefslogtreecommitdiff
path: root/odoo
diff options
context:
space:
mode:
authorXavier Morel <xmo@odoo.com>2017-05-10 16:34:36 +0200
committerXavier Morel <xmo@odoo.com>2017-05-12 16:15:40 +0200
commit07ab8b6cd2b44aeb91dadc35adf5f4b19f1399b2 (patch)
treee11bc7b07e68ff4ee0a07c1a786abd2f3abe27a8 /odoo
parent3dd3790597e84186d922b798aa8bb4650513ce4b (diff)
[FIX] P3: Exception.message removed
Diffstat (limited to 'odoo')
-rw-r--r--odoo/addons/base/ir/ir_model.py2
-rw-r--r--odoo/addons/base/ir/ir_qweb/assetsbundle.py4
-rw-r--r--odoo/addons/base/ir/ir_ui_view.py2
-rw-r--r--odoo/loglevels.py2
-rw-r--r--odoo/service/wsgi_server.py19
-rw-r--r--odoo/tools/xml_utils.py2
6 files changed, 12 insertions, 19 deletions
diff --git a/odoo/addons/base/ir/ir_model.py b/odoo/addons/base/ir/ir_model.py
index 2ff66b455de..374ff5edc15 100644
--- a/odoo/addons/base/ir/ir_model.py
+++ b/odoo/addons/base/ir/ir_model.py
@@ -406,7 +406,7 @@ class IrModelFields(models.Model):
try:
field = self._related_field()
except UserError as e:
- return {'warning': {'title': _("Warning"), 'message': e.message}}
+ return {'warning': {'title': _("Warning"), 'message': e}}
self.ttype = field.type
self.relation = field.comodel_name
self.readonly = True
diff --git a/odoo/addons/base/ir/ir_qweb/assetsbundle.py b/odoo/addons/base/ir/ir_qweb/assetsbundle.py
index 19902e78d1b..6a8ad84c9dd 100644
--- a/odoo/addons/base/ir/ir_qweb/assetsbundle.py
+++ b/odoo/addons/base/ir/ir_qweb/assetsbundle.py
@@ -524,7 +524,7 @@ class JavascriptAsset(WebAsset):
try:
return super(JavascriptAsset, self)._fetch_content()
except AssetError as e:
- return "console.error(%s);" % json.dumps(e.message)
+ return "console.error(%s);" % json.dumps(str(e))
def to_html(self):
if self.url:
@@ -573,7 +573,7 @@ class StylesheetAsset(WebAsset):
return content
except AssetError as e:
- self.bundle.css_errors.append(e.message)
+ self.bundle.css_errors.append(str(e))
return ''
def minify(self):
diff --git a/odoo/addons/base/ir/ir_ui_view.py b/odoo/addons/base/ir/ir_ui_view.py
index 0a709985ff6..3e674b02a48 100644
--- a/odoo/addons/base/ir/ir_ui_view.py
+++ b/odoo/addons/base/ir/ir_ui_view.py
@@ -1200,4 +1200,4 @@ actual arch.
try:
self.browse(vid)._check_xml()
except Exception as e:
- self.raise_view_error("Can't validate view:\n%s" % (e.message or repr(e)), vid)
+ self.raise_view_error("Can't validate view:\n%s" % e, vid)
diff --git a/odoo/loglevels.py b/odoo/loglevels.py
index 400f08e1a8f..8c0242867d2 100644
--- a/odoo/loglevels.py
+++ b/odoo/loglevels.py
@@ -92,8 +92,6 @@ def ustr(value, hint_encoding='utf-8', errors='strict'):
def exception_to_unicode(e):
- if (sys.version_info[:2] < (2,6)) and hasattr(e, 'message'):
- return ustr(e.message)
if hasattr(e, 'args'):
return "\n".join((ustr(a) for a in e.args))
try:
diff --git a/odoo/service/wsgi_server.py b/odoo/service/wsgi_server.py
index afcac829856..46c589157c1 100644
--- a/odoo/service/wsgi_server.py
+++ b/odoo/service/wsgi_server.py
@@ -85,17 +85,12 @@ def xmlrpc_handle_exception_int(e):
fault = xmlrpclib.Fault(RPC_FAULT_CODE_APPLICATION_ERROR, formatted_info)
response = xmlrpclib.dumps(fault, allow_none=False, encoding=None)
else:
- if hasattr(e, 'message') and e.message == 'AccessDenied': # legacy
- fault = xmlrpclib.Fault(RPC_FAULT_CODE_ACCESS_DENIED, str(e))
- response = xmlrpclib.dumps(fault, allow_none=False, encoding=None)
- #InternalError
- else:
- info = sys.exc_info()
- # Which one is the best ?
- formatted_info = "".join(traceback.format_exception(*info))
- #formatted_info = odoo.tools.exception_to_unicode(e) + '\n' + info
- fault = xmlrpclib.Fault(RPC_FAULT_CODE_APPLICATION_ERROR, formatted_info)
- response = xmlrpclib.dumps(fault, allow_none=None, encoding=None)
+ info = sys.exc_info()
+ # Which one is the best ?
+ formatted_info = "".join(traceback.format_exception(*info))
+ #formatted_info = odoo.tools.exception_to_unicode(e) + '\n' + info
+ fault = xmlrpclib.Fault(RPC_FAULT_CODE_APPLICATION_ERROR, formatted_info)
+ response = xmlrpclib.dumps(fault, allow_none=None, encoding=None)
return response
def xmlrpc_handle_exception_string(e):
@@ -116,7 +111,7 @@ def xmlrpc_handle_exception_string(e):
elif isinstance(e, odoo.exceptions.DeferredException):
info = e.traceback
formatted_info = "".join(traceback.format_exception(*info))
- fault = xmlrpclib.Fault(odoo.tools.ustr(e.message), formatted_info)
+ fault = xmlrpclib.Fault(odoo.tools.ustr(e), formatted_info)
response = xmlrpclib.dumps(fault, allow_none=False, encoding=None)
#InternalError
else:
diff --git a/odoo/tools/xml_utils.py b/odoo/tools/xml_utils.py
index df4c5669644..b7c03a87f53 100644
--- a/odoo/tools/xml_utils.py
+++ b/odoo/tools/xml_utils.py
@@ -13,4 +13,4 @@ def check_with_xsd(tree_or_str, xsd_path):
except etree.DocumentInvalid as xml_errors:
#import UserError only here to avoid circular import statements with tools.func being imported in exceptions.py
from odoo.exceptions import UserError
- raise UserError('\n'.join([e.message for e in xml_errors.error_log]))
+ raise UserError('\n'.join(str(e) for e in xml_errors.error_log))