diff options
| author | Xavier Morel <xmo@odoo.com> | 2018-06-19 12:11:59 +0200 |
|---|---|---|
| committer | Xavier Morel <xmo@odoo.com> | 2018-07-16 11:44:32 +0200 |
| commit | 93c0d7e811da0e64d03bfea0f131c6ace1fbde05 (patch) | |
| tree | 9f2816352b39523e1828281fde3f208d613dcdd7 /odoo/tools/convert.py | |
| parent | 233874d5efa00529a6d23a33a8b0b75d535e1950 (diff) | |
[IMP] de-commit-ify db/module install
Try to remove cr.commit (and rollback) from module and db install:
* put a savepoint around test data loading
* remove a bunch of commits sprinkled throughout
* remove rollback on data loading failure (assuming it bubbles up, the
entire module's installation should be rolled back)
* add commit right before the tests are run, so they can run isolated
and still see whatever was done when installing their module
* convert a few explicit closing to context managers
Diffstat (limited to 'odoo/tools/convert.py')
| -rw-r--r-- | odoo/tools/convert.py | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/odoo/tools/convert.py b/odoo/tools/convert.py index ceb19111650..02cee45c11f 100644 --- a/odoo/tools/convert.py +++ b/odoo/tools/convert.py @@ -742,7 +742,6 @@ form: module.record_id""" % (xml_id,) try: self._tags[rec.tag](rec, de, mode=mode) except Exception as e: - self.cr.rollback() exc_info = sys.exc_info() pycompat.reraise( ParseError, |