summaryrefslogtreecommitdiff
path: root/odoo/tools/cache.py
diff options
context:
space:
mode:
authorRaphael Collet <rco@odoo.com>2017-05-03 11:43:05 +0200
committerRaphael Collet <rco@odoo.com>2017-05-03 15:41:05 +0200
commitb59318ec12a1ce4e59de6d7bcde7146545b6c044 (patch)
treef1c23d20305c2dfae87e3f2ad27e6fa525c00f27 /odoo/tools/cache.py
parent1458f1b3135d373dac0625c7d4bd4a7eea3eaf54 (diff)
[REF] registry: always perform registry/cache signaling at the end of request
Problem: the update of custom models/fields is not fully transactional, and may potentially lead to an inconsistent database. An other problem is creating two custom fields by writing on a model: if the second one fails, the first one has been committed without notice. Retrying the request will give an unexpected error (duplicate field name). Solution: never commit in the middle of a request. If the changes have an impact on the registry, then mark it as invalid (with a new flag), and signal registry invalidation after everything has been committed. If the request fails, reset the registry. Both registry and cache invalidation are handled the same way.
Diffstat (limited to 'odoo/tools/cache.py')
-rw-r--r--odoo/tools/cache.py4
1 files changed, 1 insertions, 3 deletions
diff --git a/odoo/tools/cache.py b/odoo/tools/cache.py
index 3703fc83ab1..48dc42ba04c 100644
--- a/odoo/tools/cache.py
+++ b/odoo/tools/cache.py
@@ -92,9 +92,7 @@ class ormcache(object):
def clear(self, model, *args):
""" Clear the registry cache """
- d, key0, _ = self.lru(model)
- d.clear()
- model.pool.cache_cleared = True
+ model.pool._clear_cache()
class ormcache_context(ormcache):