diff options
| author | xmo-odoo <xmo@odoo.com> | 2017-05-10 09:39:55 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-05-10 09:39:55 +0200 |
| commit | fffaf735f58f1ac57781c095eb552de6d1fcdc47 (patch) | |
| tree | 88ab0ab65430d871862a836524e0ecc890d1674d /odoo/tests/common.py | |
| parent | 10eee18a047d35305dc46282e610e88936d81ffc (diff) | |
[FIX] P3: list -> iterable builtins (#16811)
In Python 3:
* various builtins and dict methods were changed to return
view/iterable objects rather than lists
* and the separate Python 2 view/iterable builtins and methods were
removed altogether
This is problematic when using these items as list (which the happens
repeatedly in Odoo), but more viciously when iterating *multiple times*
over them (which also happens, which I've messed up multiple times while
writing this, and which is a pain to debug even when you've just created
the issue).
Convert all code using these to semantics-matching cross-version
helper functions to get the LCD behaviour between P2 and P3, and
forbid the builtins via lint.
issue #8530
Diffstat (limited to 'odoo/tests/common.py')
| -rw-r--r-- | odoo/tests/common.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/odoo/tests/common.py b/odoo/tests/common.py index 78cfbfbdbf9..a491c23ef76 100644 --- a/odoo/tests/common.py +++ b/odoo/tests/common.py @@ -135,7 +135,7 @@ class BaseCase(unittest.TestCase): def shortDescription(self): doc = self._testMethodDoc - return doc and ' '.join(filter(None, map(str.strip, doc.splitlines()))) or None + return doc and ' '.join(l.strip() for l in doc.splitlines() if not l.isspace()) or None class TransactionCase(BaseCase): |