diff options
| author | Yannick Tivisse <yti@odoo.com> | 2017-05-22 17:28:54 +0200 |
|---|---|---|
| committer | Yannick Tivisse <yti@odoo.com> | 2017-05-26 13:13:12 +0200 |
| commit | 7e008469e4e5afe9b4c7151a4738240462359f98 (patch) | |
| tree | 8d53bc636b26341afc4ac66616068afc273d9c8c /odoo/import_xml.rng | |
| parent | 6110eb969da0397636a0aa4427b7bcc1334eee09 (diff) | |
[IMP] base: Always load menuitem xmlids on templates
PURPOSE
=======
Currently we can choose to load the xmlid of a menuitem if web_tour is installed by setting the attribute `load_xmlid=True` on the view.
This is strange for 2 reasons:
- Searching all the ir.model.data on menuitems with load_xmlid=True to compute its xmlid, searching the related subtree on the returned structure of the method load_menus is quite complicated for the perfomance gain (if there is any perfomance gain to do it)
- This is not working in community in frontend, as only the root menuitems are loaded, thus it is the `load_menus_root` instead of the `load_menus` that is called. This issue prevent a tour step to be displayed correctly on community and enterprise on a menuitem.
SPECIFICATION
=============
Remove all the `load_xmlid` attributes and the related mechanism and move it into base to always load the xmlids for all the menuitems. It won't bee to heavy as the result is cached.
It's better the keep the current mechanism (Load the xmlids from ir.model.data and insert them into the tree) as we only make 1 search to the ir.model.data
Diffstat (limited to 'odoo/import_xml.rng')
| -rw-r--r-- | odoo/import_xml.rng | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/odoo/import_xml.rng b/odoo/import_xml.rng index 81fef2b35c6..36546c39946 100644 --- a/odoo/import_xml.rng +++ b/odoo/import_xml.rng @@ -239,9 +239,6 @@ <rng:optional> <rng:attribute name="action"/> </rng:optional> <rng:optional> <rng:attribute name="sequence"/> </rng:optional> <rng:optional> <rng:attribute name="groups"/> </rng:optional> - <rng:optional> - <rng:attribute name="load_xmlid"><rng:value>True</rng:value></rng:attribute> - </rng:optional> <!-- TODO: remove icon stuff --> <rng:optional> <rng:attribute name="icon"/> </rng:optional> <rng:optional> <rng:attribute name="web_icon"/> </rng:optional> |