[REF] fields: use ir.model.fields.selection

The selection values of a selection field are now stored in database in the
model ir.model.fields.selection

This will allow to have a modular approche on selections and each selection
is now linked to the module that declared it.
Previously to this change, the selections were linked to the field, meaning
uninstalling a module had no impact on the selections stored on database.

With this change, the selections will now be translated in the correct module
(having an external id) and the records having a used selection will now be
reset to null.

closes odoo/odoo#30228

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>


Co-authored-by: Raphaël Collet <rco@odoo.com>

1 files changed, 20 insertions, 4 deletions

diff --git a/odoo/fields.py b/odoo/fields.py
index b8c964aaa79..daa28dff6e1 100644
--- a/odoo/fields.py
+++ b/odoo/fields.py
@@ -1980,6 +1980,25 @@ class Selection(Field):
                 selection_add = field.args['selection_add']
                 self.selection = list(OrderedDict(self.selection + selection_add).items())
 
+    def _selection_modules(self, model):
+        """ Return a mapping from selection values to modules defining each value. """
+        if not isinstance(self.selection, list):
+            return {}
+        value_modules = defaultdict(set)
+        for field in reversed(resolve_mro(model, self.name, self._can_setup_from)):
+            module = field.args.get('_module')
+            if not module:
+                continue
+            if 'selection' in field.args:
+                value_modules.clear()
+                if isinstance(field.args['selection'], list):
+                    for value, label in field.args['selection']:
+                        value_modules[value].add(module)
+            if 'selection_add' in field.args:
+                for value, label in field.args['selection_add']:
+                    value_modules[value].add(module)
+        return value_modules
+
     def _description_selection(self, env):
         """ return the selection list (pairs (value, label)); labels are
             translated according to context language
@@ -1992,10 +2011,7 @@ class Selection(Field):
 
         # translate selection labels
         if env.lang:
-            name = "%s,%s" % (self.model_name, self.name)
-            translate = partial(
-                env['ir.translation']._get_source, name, 'selection', env.lang)
-            return [(value, translate(label) if label else label) for value, label in selection]
+            return env['ir.translation'].get_field_selection(self.model_name, self.name)
         else:
             return selection