[CHG] *: make binary fields default to attachment=True

Check that it makes custom binary fields into attachment as that's the
main reason for the change: when users create binary fields via Studio,
they're necessarily db-stored (as the interface doesn't allow altering
the attachment attribute and it's unclear how we'd handle users
switching it on/off every time), which significantly bloats their
database (and burns storage & backup space), especially as the primary
use case for binary fields is adding images and documents to records.

* check that binary fields are properly created as attachment=True
* add attachment=False on fields where that seems relevant (most but not
  all of the fields previously using the default)
* remove occurrences of attachment=True

closes odoo/odoo#29308

1 files changed, 1 insertions, 1 deletions

diff --git a/odoo/fields.py b/odoo/fields.py
index a69edde187d..014f658f3b9 100644
--- a/odoo/fields.py
+++ b/odoo/fields.py
@@ -1742,7 +1742,7 @@ class Binary(Field):
     _slots = {
         'prefetch': False,              # not prefetched by default
         'context_dependent': True,      # depends on context (content or size)
-        'attachment': False,            # whether value is stored in attachment
+        'attachment': True,             # whether value is stored in attachment
     }
 
     @property