[FIX] base: tools: float_split_str: avoid traceback when rounding to 0 places and add some test cases

closes odoo/odoo#67949

X-original-commit: 42d409f180381316c97abd0c0ef5a062656e6122
Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

1 files changed, 22 insertions, 9 deletions

diff --git a/odoo/addons/base/tests/test_float.py b/odoo/addons/base/tests/test_float.py
index 8196c2433ab..5e1db6c074f 100644
--- a/odoo/addons/base/tests/test_float.py
+++ b/odoo/addons/base/tests/test_float.py
@@ -4,7 +4,7 @@
 from math import log10
 
 from odoo.tests.common import TransactionCase
-from odoo.tools import float_compare, float_is_zero, float_repr, float_round, float_split_str
+from odoo.tools import float_compare, float_is_zero, float_repr, float_round, float_split, float_split_str
 
 
 class TestFloatPrecision(TransactionCase):
@@ -186,16 +186,29 @@ class TestFloatPrecision(TransactionCase):
         """ Test split method with 2 digits. """
         currency = self.env.ref('base.EUR')
 
-        def try_split(value, expected):
-            digits = max(0, -int(log10(currency.rounding)))
-            result = float_split_str(value, precision_digits=digits)
+        def try_split(value, expected, split_fun, rounding=None):
+            digits = max(0, -int(log10(currency.rounding))) if rounding is None else rounding
+            result = split_fun(value, precision_digits=digits)
             self.assertEqual(result, expected, 'Split error: got %s, expected %s' % (result, expected))
 
-        try_split(2.674, ('2', '67'))
-        try_split(2.675, ('2', '68'))   # in Python 2.7.2, round(2.675,2) gives 2.67
-        try_split(-2.675, ('-2', '68')) # in Python 2.7.2, round(2.675,2) gives 2.67
-        try_split(0.001, ('0', '00'))
-        try_split(-0.001, ('-0', '00'))
+        try_split(2.674, ('2', '67'), float_split_str)
+        try_split(2.675, ('2', '68'), float_split_str)   # in Python 2.7.2, round(2.675,2) gives 2.67
+        try_split(-2.675, ('-2', '68'), float_split_str) # in Python 2.7.2, round(2.675,2) gives 2.67
+        try_split(0.001, ('0', '00'), float_split_str)
+        try_split(-0.001, ('-0', '00'), float_split_str)
+        try_split(42, ('42', '00'), float_split_str)
+        try_split(0.1, ('0', '10'), float_split_str)
+        try_split(13.0, ('13', ''), float_split_str, rounding=0)
+
+        try_split(2.674, (2, 67), float_split)
+        try_split(2.675, (2, 68), float_split)   # in Python 2.7.2, round(2.675,2) gives 2.67
+        try_split(-2.675, (-2, 68), float_split) # in Python 2.7.2, round(2.675,2) gives 2.67
+        try_split(0.001, (0, 0), float_split)
+        try_split(-0.001, (0, 0), float_split)
+        try_split(42, (42, 0), float_split)
+        try_split(0.1, (0, 10), float_split)
+        try_split(13.0, (13, 0), float_split, rounding=0)
+
 
     def test_rounding_invalid(self):
         """ verify that invalid parameters are forbidden """