diff options
| author | oco-odoo <oco@odoo.com> | 2021-03-23 15:29:47 +0000 |
|---|---|---|
| committer | oco-odoo <oco@odoo.com> | 2021-04-02 09:45:24 +0000 |
| commit | 72b7fb15db4df1a3336bc6e90fe60f49877c52f8 (patch) | |
| tree | de67d641390772c696460bb9c493ef9c7e590d7e /odoo/addons | |
| parent | 72c29b105bdb4da5b306cd3b48a1683c1bf3e620 (diff) | |
[FIX] base_vat: Don't always pass VAT check when validating the VAT of a partner without country_id
Before this, when making a partner without any country_id, any VAT could be set to it, which was inconsistent with the module's purpose.
closes odoo/odoo#68492
X-original-commit: 4c962437bd59a1e9302d8034e8870880994eb713
Related: odoo/enterprise#17358
Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
Diffstat (limited to 'odoo/addons')
| -rw-r--r-- | odoo/addons/base/tests/test_base.py | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/odoo/addons/base/tests/test_base.py b/odoo/addons/base/tests/test_base.py index eef6c749095..f28d1f7c2e5 100644 --- a/odoo/addons/base/tests/test_base.py +++ b/odoo/addons/base/tests/test_base.py @@ -196,7 +196,7 @@ class TestBase(TransactionCase): self.assertEqual(p1.street, p1street, 'Address fields must not be synced after turning sync off') self.assertNotEqual(ghoststep.street, p1street, 'Parent address must never be touched') - # turn on sync again + # turn on sync again p1.write({'type': 'contact'}) self.assertEqual(p1.street, ghoststep.street, 'Address fields must be synced again') self.assertEqual(p1.phone, p1phone, 'Phone should be preserved after address sync') @@ -383,12 +383,12 @@ class TestBase(TransactionCase): for p in (p0, p1, p11, p2, p3): self.assertEqual(p.commercial_partner_id, sunhelm, 'Incorrect commercial entity resolution') self.assertEqual(p.vat, sunhelm.vat, 'Commercial fields must be automatically synced') - sunhelmvat = 'BE0123456789' + sunhelmvat = 'BE0123456749' sunhelm.write({'vat': sunhelmvat}) for p in (p0, p1, p11, p2, p3): self.assertEqual(p.vat, sunhelmvat, 'Commercial fields must be automatically and recursively synced') - p1vat = 'BE0987654321' + p1vat = 'BE0987654394' p1.write({'vat': p1vat}) for p in (sunhelm, p0, p11, p2, p3): self.assertEqual(p.vat, sunhelmvat, 'Sync to children should only work downstream and on commercial entities') @@ -401,7 +401,7 @@ class TestBase(TransactionCase): self.assertEqual(p1.commercial_partner_id, p1, 'Incorrect commercial entity resolution after setting is_company') # writing on parent should not touch child commercial entities - sunhelmvat2 = 'BE0112233445' + sunhelmvat2 = 'BE0112233453' sunhelm.write({'vat': sunhelmvat2}) self.assertEqual(p1.vat, p1vat, 'Setting is_company should stop auto-sync of commercial fields') self.assertEqual(p0.vat, sunhelmvat2, 'Commercial fields must be automatically synced') |