diff options
| author | Martin Trigaux <mat@odoo.com> | 2020-02-14 11:22:15 +0100 |
|---|---|---|
| committer | Martin Trigaux <mat@odoo.com> | 2020-05-14 13:59:10 +0200 |
| commit | d9287caf9408bb4ff85ad734cbca08e44321e205 (patch) | |
| tree | 0d3b7c5705e5172176a7d76bf9098e381190bf4b /odoo/addons/test_assetsbundle | |
| parent | 56a8c9e4311d24c33b7ad08b8230e4be345a85b8 (diff) | |
[IMP] *: convert to private methods
render, render_template, load, activity_schedule_with_view,
get_website_pages should all be private:
It should not be possible to render an aribtrary template only with
its name or id
Still need to render some qweb views from js so the method
render_template is kept public.
This explains why the website editor still need read access on
ir.ui.view as we want to allow any snippet to be rendered.
Diffstat (limited to 'odoo/addons/test_assetsbundle')
| -rw-r--r-- | odoo/addons/test_assetsbundle/controllers/main.py | 2 | ||||
| -rw-r--r-- | odoo/addons/test_assetsbundle/tests/test_assetsbundle.py | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/odoo/addons/test_assetsbundle/controllers/main.py b/odoo/addons/test_assetsbundle/controllers/main.py index 4af6ed14b8e..f6da2ab929b 100644 --- a/odoo/addons/test_assetsbundle/controllers/main.py +++ b/odoo/addons/test_assetsbundle/controllers/main.py @@ -10,4 +10,4 @@ class TestAssetsBundleController(Controller): env = request.env(user=SUPERUSER_ID) bundle = env.ref('test_assetsbundle.bundle1') views = env['ir.ui.view'].search([('inherit_id', '=', bundle.id)]) - return views.with_context(check_view_ids=views.ids).render_template('test_assetsbundle.template1') + return views.with_context(check_view_ids=views.ids)._render_template('test_assetsbundle.template1') diff --git a/odoo/addons/test_assetsbundle/tests/test_assetsbundle.py b/odoo/addons/test_assetsbundle/tests/test_assetsbundle.py index c38245eb19e..7399983af55 100644 --- a/odoo/addons/test_assetsbundle/tests/test_assetsbundle.py +++ b/odoo/addons/test_assetsbundle/tests/test_assetsbundle.py @@ -471,7 +471,7 @@ class TestJavascriptAssetsBundle(FileTouchable): self.assertEqual(len(css_bundle), 1) def test_20_exteral_lib_assets(self): - html = self.env['ir.ui.view'].render_template('test_assetsbundle.template2') + html = self.env['ir.ui.view']._render_template('test_assetsbundle.template2') attachments = self.env['ir.attachment'].search([('url', '=like', '/web/content/%-%/test_assetsbundle.bundle4.%')]) self.assertEqual(len(attachments), 2) self.assertEqual(html.strip(), ("""<!DOCTYPE html> @@ -490,7 +490,7 @@ class TestJavascriptAssetsBundle(FileTouchable): </html>""" % {"js": attachments[0].url, "css": attachments[1].url}).encode('utf8')) def test_21_exteral_lib_assets_debug_mode(self): - html = self.env['ir.ui.view'].render_template('test_assetsbundle.template2', {"debug": "assets"}) + html = self.env['ir.ui.view']._render_template('test_assetsbundle.template2', {"debug": "assets"}) attachments = self.env['ir.attachment'].search([('url', '=like', '/web/content/%-%/test_assetsbundle.bundle4.%')]) self.assertEqual(len(attachments), 0) self.assertEqual(html.strip(), ("""<!DOCTYPE html> |