summaryrefslogtreecommitdiff
path: root/odoo/addons/base/wizard
diff options
context:
space:
mode:
authorVictor Feyens <vfe@odoo.com>2020-07-14 14:29:10 +0000
committerVictor Feyens <vfe@odoo.com>2020-07-23 16:38:17 +0000
commit71ab12840bc787ca486202255cd6faa21281b9e1 (patch)
treedc8b093e25f9215f2f2c53ff0a084500c88ef560 /odoo/addons/base/wizard
parentc69a092b98ad7a7f8e03024d170efa30038c89a0 (diff)
[IMP] *: do not specify unwanted defaults in default_get
When default_get is called, the wanted fields are specified through the fields_list arg. It is useless to fill the values for unwanted fields. As default_get is called for nearly all records creation, simplifying the default_get overrides: * remove potential wrong side-effects of the values * remove some useless or wrong defaults computations (searches, refs, ...)
Diffstat (limited to 'odoo/addons/base/wizard')
-rw-r--r--odoo/addons/base/wizard/base_partner_merge.py9
1 files changed, 6 insertions, 3 deletions
diff --git a/odoo/addons/base/wizard/base_partner_merge.py b/odoo/addons/base/wizard/base_partner_merge.py
index 2bd97ff085e..484964e3558 100644
--- a/odoo/addons/base/wizard/base_partner_merge.py
+++ b/odoo/addons/base/wizard/base_partner_merge.py
@@ -41,9 +41,12 @@ class MergePartnerAutomatic(models.TransientModel):
res = super(MergePartnerAutomatic, self).default_get(fields)
active_ids = self.env.context.get('active_ids')
if self.env.context.get('active_model') == 'res.partner' and active_ids:
- res['state'] = 'selection'
- res['partner_ids'] = [(6, 0, active_ids)]
- res['dst_partner_id'] = self._get_ordered_partner(active_ids)[-1].id
+ if 'state' in fields:
+ res['state'] = 'selection'
+ if 'partner_ids' in fields:
+ res['partner_ids'] = [(6, 0, active_ids)]
+ if 'dst_partner_id' in fields:
+ res['dst_partner_id'] = self._get_ordered_partner(active_ids)[-1].id
return res
# Group by