[FIX] P3: list -> iterable builtins (#16811)

In Python 3:

* various builtins and dict methods were changed to return
  view/iterable objects rather than lists
* and the separate Python 2 view/iterable builtins and methods were
  removed altogether

This is problematic when using these items as list (which the happens
repeatedly in Odoo), but more viciously when iterating *multiple times*
over them (which also happens, which I've messed up multiple times while
writing this, and which is a pain to debug even when you've just created
the issue).

Convert all code using these to semantics-matching cross-version
helper functions to get the LCD behaviour between P2 and P3, and
forbid the builtins via lint.

issue #8530

1 files changed, 3 insertions, 3 deletions

diff --git a/odoo/addons/base/tests/test_float.py b/odoo/addons/base/tests/test_float.py
index 8c4ee380bd2..725ba48365b 100644
--- a/odoo/addons/base/tests/test_float.py
+++ b/odoo/addons/base/tests/test_float.py
@@ -98,10 +98,10 @@ class TestFloatPrecision(TransactionCase):
         precisions = [2, 2, 2, 2, 2, 2, 3, 4]
         # Note: max precision for double floats is 53 bits of precision or
         # 17 significant decimal digits
-        for magnitude in pycompat.range(7):
-            for frac, exp, prec in zip(fractions, expecteds, precisions):
+        for magnitude in range(7):
+            for frac, exp, prec in pycompat.izip(fractions, expecteds, precisions):
                 for sign in [-1,1]:
-                    for x in pycompat.range(0, 10000, 97):
+                    for x in range(0, 10000, 97):
                         n = x * 10 ** magnitude
                         f = sign * (n + frac)
                         f_exp = ('-' if f != 0 and sign == -1 else '') + str(n) + exp