[IMP] tools: float_utils, precision rounding must be positive

Adding a new rule to verify that precision_rounding is positive.

Before this commit:
when a precision_round was 0 or smaller than 0 the float_utils
functions gave as results:
* float_is_zero(0.0, precision_rounding=0.0) -> False
* float_round(1.25, precision_rounding=0.0) -> 0.0
* float_compare(1.0, 1.0, precision_rounding=0.0) -> 1

These results where at least not correct at worst not logic.

Now, the function raises an error when the precision_rounding
is not positive

1 files changed, 18 insertions, 0 deletions

diff --git a/odoo/addons/base/tests/test_float.py b/odoo/addons/base/tests/test_float.py
index 4447b9de1c0..4dbf1f5f139 100644
--- a/odoo/addons/base/tests/test_float.py
+++ b/odoo/addons/base/tests/test_float.py
@@ -202,11 +202,29 @@ class TestFloatPrecision(TransactionCase):
             float_is_zero(0.01, precision_digits=3, precision_rounding=0.01)
 
         with self.assertRaises(AssertionError):
+            float_is_zero(0.0, precision_rounding=0.0)
+
+        with self.assertRaises(AssertionError):
+            float_is_zero(0.0, precision_rounding=-0.1)
+
+        with self.assertRaises(AssertionError):
             float_compare(0.01, 0.02, precision_digits=3, precision_rounding=0.01)
 
         with self.assertRaises(AssertionError):
+            float_compare(1.0, 1.0, precision_rounding=0.0)
+
+        with self.assertRaises(AssertionError):
+            float_compare(1.0, 1.0, precision_rounding=-0.1)
+
+        with self.assertRaises(AssertionError):
             float_round(0.01, precision_digits=3, precision_rounding=0.01)
 
+        with self.assertRaises(AssertionError):
+            float_round(1.25, precision_rounding=0.0)
+
+        with self.assertRaises(AssertionError):
+            float_round(1.25, precision_rounding=-0.1)
+
     def test_amount_to_text_10(self):
         """ verify that amount_to_text works as expected """
         currency = self.env.ref('base.EUR')