diff options
| author | Victor Feyens <vfe@odoo.com> | 2020-08-18 12:26:51 +0000 |
|---|---|---|
| committer | Thibault Delavallée <tde@odoo.com> | 2020-08-31 11:45:43 +0000 |
| commit | 1cc6bb1231401ea7f501d2f5b5e9641ec8734850 (patch) | |
| tree | 9c6da86e0a5a13368365c895e77ede2b1ebac3d9 /odoo/addons/base/models/ir_module.py | |
| parent | df06d7f9c488ab3e463baed10b55bea8bbfb5908 (diff) | |
[IMP] various: improve code style and performance by improve ``all()`` usage
PURPOSE
Clean code. Be more performance oriented.
SPECIFICATIONS
Improvements applied in this commit
* not all() --> any(not) for earlier returns;
* all([generator]) --> all(generator) to avoid unnecessary list casting.
This code construct is better managed by all;
This commit will probably not have a big performance effect on standard
production databases. However each performance and cleaning improvement
is welcomed.
LINKS
Task ID-2328619
closes odoo/odoo#56060
Related: odoo/enterprise#12486
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Diffstat (limited to 'odoo/addons/base/models/ir_module.py')
| -rw-r--r-- | odoo/addons/base/models/ir_module.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/odoo/addons/base/models/ir_module.py b/odoo/addons/base/models/ir_module.py index 57cbe796014..050fa4a978a 100644 --- a/odoo/addons/base/models/ir_module.py +++ b/odoo/addons/base/models/ir_module.py @@ -619,7 +619,7 @@ class Module(models.Model): def button_uninstall(self): if 'base' in self.mapped('name'): raise UserError(_("The `base` module cannot be uninstalled")) - if not all(state in ('installed', 'to upgrade') for state in self.mapped('state')): + if any(state not in ('installed', 'to upgrade') for state in self.mapped('state')): raise UserError(_( "One or more of the selected modules have already been uninstalled, if you " "believe this to be an error, you may try again later or contact support." |