diff options
| author | Nans Lefebvre <len@odoo.com> | 2019-09-30 12:38:34 +0000 |
|---|---|---|
| committer | fw-bot <otis@odoo.com> | 2019-10-10 06:27:45 +0000 |
| commit | b1a3e6bd04c81453b7ea019ac70b40307fe7644d (patch) | |
| tree | 18c645a4631f83e15c0931ccfb26eaf645b809f3 /doc/reference | |
| parent | 012343ef1360f1baabea0c59a11d1394252e402d (diff) | |
[FIX] ir_http: return a 404 if binary content cannot be decoded
Commit 5a9e1af64acc has the unfortunate side-effect of crashing early
if for any reason the content cannot be decoded.
However, simply ignoring that the content cannot be decoded is no better idea:
some functions pipe the result to decoding functions that crash the same.
The resulting traceback pollutes the log with uninformative message such as:
binascii.Error: Incorrect padding 5 0.002 0.016
In case the content cannot be decoded (data corruption, or simply missing file)
we return a clean 404 instead, which is morally almost equivalent,
and is clean even from functions that depend on binary_content.
opw 2072586
closes odoo/odoo#38318
X-original-commit: a68f7e6e72dbfd44e14c2f293fa6dc6aa402308a
Signed-off-by: Nans Lefebvre (len) <len@odoo.com>
Diffstat (limited to 'doc/reference')
0 files changed, 0 insertions, 0 deletions
