diff options
| author | fw-bot <otis@odoo.com> | 2019-10-30 11:27:49 +0000 |
|---|---|---|
| committer | Xavier-Do <xdo@odoo.com> | 2019-10-30 13:36:43 +0000 |
| commit | f11cb858be2b32bd02667279751f52a981f50976 (patch) | |
| tree | 7bed3cbbb493e3e5a138644b2fe817cd2f27126e /doc/reference/javascript_reference.rst | |
| parent | 8d5da6e4be05428f3243f92c0464d3c1f6a43873 (diff) | |
[FIX] core: remove broken time consuming checks
The two method valid valid_alternative_icon_text and valid_title_icon
represent ~13% of an install all. Rewriting them in master
with in #36373 is the main reason of the performance improvement.
Those two method logic were broken, because
`xpath += '[not(//*[' + valid_attrs_xpath + '])]'`
will actually search for valid_attrs_xpath from view root,
not from fa- node.
-since this check will only log a warning and so only impact
bugfix, no impact on user editing views,
-since a new check is added in master with the corresponding fix in views,
-since this check doesn't really test what it is suppose to check,
-since fa accessibility is great, but not critical
->removing those check will slightly speed up build without major impact
on views quality
closes odoo/odoo#39566
Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
Diffstat (limited to 'doc/reference/javascript_reference.rst')
0 files changed, 0 insertions, 0 deletions
