[FIX] core: use shortened table aliasing in get_join_conditions()

Current behavior:
Auto-generated SQL fails with ERROR: missing FROM-clause entry for table when table alias names exceed the target length of 63 characters. This is because odoo.osv.expression.py handles shortening the table name alias in generate_table_alias, but not in get_join_conditions. In the resulting SQL, shortened aliases are used in the FROM clause, whereas in the join conditions, the full alias is used, which is both exceeding the Postgres limit and not matching the table name alias in the FROM clause.

Expected behavior:
auto-generated SQL runs without errors.

Implementation of fix:
- refactor alias shortening into new function _shorten_alias to make it reusable
- Use _shorten_alias in both generate_table_alias and get_join_conditions

closes odoo/odoo#57909

X-original-commit: 9570f5ff4694a58035094ad52b4773433dbd018c
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

1 files changed, 16 insertions, 0 deletions

diff --git a/doc/cla/corporate/coloop.md b/doc/cla/corporate/coloop.md
new file mode 100644
index 00000000000..ed8b37470ca
--- /dev/null
+++ b/doc/cla/corporate/coloop.md
@@ -0,0 +1,16 @@
+United Kingdom, 2020-07-21
+
+Coloop Ltd. agrees to the terms of the Odoo Corporate Contributor License
+Agreement v1.0.
+
+I declare that I am authorized and able to make this agreement and sign this
+declaration.
+
+Signed,
+
+Alex Hafner alex.hafner@coloop.com https://github.com/alexhafner
+
+List of contributors:
+
+Alex Hafner alex.hafner@coloop.com https://github.com/alexhafner
+Herbert Riess herbert.riess@coloop.com https://github.com/r13ssh
\ No newline at end of file