diff options
| author | xmo-odoo <xmo-odoo@users.noreply.github.com> | 2014-05-17 11:44:09 +0200 |
|---|---|---|
| committer | xmo-odoo <xmo-odoo@users.noreply.github.com> | 2014-05-17 11:44:09 +0200 |
| commit | 59354d5bf3a4afdb0faaf1d8bbd147ddf67e9ae4 (patch) | |
| tree | 334a46ebb66dc23decefc27dc89111f0c632f7db /checkout.sh | |
| parent | c771d1ae20a6518278f7572ebdbd86f8cbbb48a4 (diff) | |
[IMP] remove setting of color.ui
After further considering PR #21's arguments, the setup script should
not go around setting `color.ui`:
* it shouldn't be needed for recent gits with default compile
settings[0]
* it may override advanced users's own colour configuration/
customisations (or disabling)
* it forces default colours on users for which it may be useless
(colour- blind) or even detrimental (other vision impairments)
* some linux distributions apparently default to idiotic pagers which
can't handle ANSI colour codes by default and spew garbage to the
terminal
[0] https://github.com/git/git/blob/master/Documentation/RelNotes/1.8.4.txt#L178-L180
Diffstat (limited to 'checkout.sh')
| -rwxr-xr-x | checkout.sh | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/checkout.sh b/checkout.sh index 5a51dd0e4da..0955508a178 100755 --- a/checkout.sh +++ b/checkout.sh @@ -57,7 +57,6 @@ cd $copyname git config user.name "$name" git config user.email "$email" -git config color.ui auto # pre-push script preventing push to odoo repo by default. Git just execs # them, so they need a correct shebang and exec bit |