[FIX] core,account: avoid useless recomputations in res.config

User may use Settings menu just to click "Manage Users" buttons. Such simple
navigation sends ``create`` request, which may trigger a chain of
recomputations. To avoid that we redefine ``create`` method to check if a value
is really changed.

The previous explicit implementation lacks in v14 two fields at least:

* from module `account`
    ```
    qr_code = fields.Boolean(string='Display SEPA QR-code', related='company_id.qr_code', readonly=False)
    ```

* from module `enterprise/account_reports`
    ```
    account_tax_fiscal_country_id = fields.Many2one(string="Fiscal Country", related="company_id.account_tax_fiscal_country_id", readonly=False)
    ```

Performance Tests
=================

In this test we click "Manage users" and check stats for
``res.config.settings/create`` request.

Demo database with eCommerce and Accounting app installed:

```
|        | Number of queries | Query time, sec | Remaining time, sec |
|--------+-------------------+-----------------+---------------------|
| Before |               707 |           0.325 |               0.215 |
| After  |               382 |           0.283 |               0.174 |
```

The same, but with extra 1400 invoices:

```
|        | Number of queries | Query time, sec | Remaining time, sec |
|--------+-------------------+-----------------+---------------------|
| Before |               715 |           0.459 |               0.349 |
| After  |               382 |           0.176 |               0.107 |
```

---

opw-2489335

closes odoo/odoo#68486

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

1 files changed, 0 insertions, 12 deletions

diff --git a/addons/account/models/res_config_settings.py b/addons/account/models/res_config_settings.py
index 457c00481b3..18c1ceb012b 100644
--- a/addons/account/models/res_config_settings.py
+++ b/addons/account/models/res_config_settings.py
@@ -162,15 +162,3 @@ class ResConfigSettings(models.TransientModel):
                              'Modify your taxes first before disabling this setting.')
             }
         return res
-
-    @api.model
-    def create(self, values):
-        # Optimisation purpose, saving a res_config even without changing any values will trigger the write of all
-        # related values, including the currency_id field on res_company. This in turn will trigger the recomputation
-        # of account_move_line related field company_currency_id which can be slow depending on the number of entries
-        # in the database. Thus, if we do not explicitly change the currency_id, we should not write it on the company
-        if ('company_id' in values and 'currency_id' in values):
-            company = self.env['res.company'].browse(values.get('company_id'))
-            if company.currency_id.id == values.get('currency_id'):
-                values.pop('currency_id')
-        return super(ResConfigSettings, self).create(values)