diff options
| author | Laurent Stukkens (LTU) <ltu@odoo.com> | 2020-11-17 15:05:03 +0000 |
|---|---|---|
| committer | Laurent Stukkens (LTU) <ltu@odoo.com> | 2020-11-17 16:28:06 +0000 |
| commit | de14be4986ef4a293b99523b7dc110be3b16b8ea (patch) | |
| tree | d8ab90b3aaac7e25af7ec34858aa06c7ad46c504 /addons | |
| parent | 1bfc5c83ae208430cfd6e3eda72dd53aa8d3a613 (diff) | |
[FIX] website, website_sale: fix race condition on dynamic snippet
Prior to this commit:
A race condition could occur when dropping the dynamic product snippet
creating a traceback "Cannot read property 'limit' of undefined".
After this commit:
Potential race condition has been removed from the code.
closes odoo/odoo#61872
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Diffstat (limited to 'addons')
| -rw-r--r-- | addons/website/static/src/snippets/s_dynamic_snippet/options.js | 5 | ||||
| -rw-r--r-- | addons/website_sale/static/src/snippets/s_dynamic_snippet_products/options.js | 5 |
2 files changed, 6 insertions, 4 deletions
diff --git a/addons/website/static/src/snippets/s_dynamic_snippet/options.js b/addons/website/static/src/snippets/s_dynamic_snippet/options.js index a39b62c2005..2cbdcb1ca38 100644 --- a/addons/website/static/src/snippets/s_dynamic_snippet/options.js +++ b/addons/website/static/src/snippets/s_dynamic_snippet/options.js @@ -62,8 +62,9 @@ const dynamicSnippetOptions = options.Class.extend({ * @override * @private */ - _renderCustomXML: function (uiFragment) { - return Promise.all([this._renderDynamicFiltersSelector(uiFragment), this._renderDynamicFilterTemplatesSelector(uiFragment)]); + _renderCustomXML: async function (uiFragment) { + await this._renderDynamicFiltersSelector(uiFragment); + await this._renderDynamicFilterTemplatesSelector(uiFragment); }, /** * Renders the dynamic filter option selector content into the provided uiFragment. diff --git a/addons/website_sale/static/src/snippets/s_dynamic_snippet_products/options.js b/addons/website_sale/static/src/snippets/s_dynamic_snippet_products/options.js index 7acf98a866c..b5b3bc7018b 100644 --- a/addons/website_sale/static/src/snippets/s_dynamic_snippet_products/options.js +++ b/addons/website_sale/static/src/snippets/s_dynamic_snippet_products/options.js @@ -68,8 +68,9 @@ const dynamicSnippetProductsOptions = s_dynamic_snippet_carousel_options.extend( * @override * @private */ - _renderCustomXML: function (uiFragment) { - return Promise.all([this._super.apply(this, arguments), this._renderProductCategorySelector(uiFragment)]); + _renderCustomXML: async function (uiFragment) { + await this._super.apply(this, arguments); + await this._renderProductCategorySelector(uiFragment); }, /** * Renders the product categories option selector content into the provided uiFragment. |