summaryrefslogtreecommitdiff
path: root/addons
diff options
context:
space:
mode:
authorThibault Delavallée <tde@odoo.com>2017-10-26 17:35:59 +0200
committerThibault Delavallée <tde@odoo.com>2017-10-27 10:36:11 +0200
commitc59597f5e034c4a979953b05b4ee06ae2dfd17fe (patch)
tree9e1da65f3284544165ae95559cd93d0500f483f8 /addons
parentb72b10c1914a6a756e7eff53cd584cce706efb6e (diff)
[FIX] (account, sale)_payment: fix s2s on not existing document
Returned error was not correct as just browsing an ID that does not exist is not sufficient. We should use exists.
Diffstat (limited to 'addons')
-rw-r--r--addons/account_payment/controllers/payment.py2
-rw-r--r--addons/sale_payment/controllers/payment.py2
2 files changed, 2 insertions, 2 deletions
diff --git a/addons/account_payment/controllers/payment.py b/addons/account_payment/controllers/payment.py
index 7427d768dad..80924b910bd 100644
--- a/addons/account_payment/controllers/payment.py
+++ b/addons/account_payment/controllers/payment.py
@@ -64,7 +64,7 @@ class PaymentPortal(http.Controller):
if access_token:
params['access_token'] = access_token
- invoice_sudo = request.env['account.invoice'].sudo().browse(invoice_id)
+ invoice_sudo = request.env['account.invoice'].sudo().browse(invoice_id).exists()
if not invoice_sudo:
params['error'] = 'pay_invoice_invalid_doc'
return request.redirect(_build_url_w_params(error_url, params))
diff --git a/addons/sale_payment/controllers/payment.py b/addons/sale_payment/controllers/payment.py
index 5183e8c58e1..54b89cf577e 100644
--- a/addons/sale_payment/controllers/payment.py
+++ b/addons/sale_payment/controllers/payment.py
@@ -64,7 +64,7 @@ class PaymentPortal(http.Controller):
if access_token:
params['access_token'] = access_token
- order_sudo = request.env['sale.order'].sudo().browse(order_id)
+ order_sudo = request.env['sale.order'].sudo().browse(order_id).exists()
if not order_sudo:
params['error'] = 'pay_sale_invalid_doc'
return request.redirect(_build_url_w_params(error_url, params))