summaryrefslogtreecommitdiff
path: root/addons
diff options
context:
space:
mode:
authorLucas Perais (lpe) <lpe@odoo.com>2018-11-28 15:26:48 +0000
committerLucas Perais (lpe) <lpe@odoo.com>2018-11-28 15:26:48 +0000
commitc432667fbf2f9b833d7fde9010f558d19666ad2f (patch)
tree45c6ef245068dad6d41ccc22a5bf250883f01d11 /addons
parent293dbe267abe0a48f3f5f16e929d09bd0bc6198d (diff)
[FIX] base,web_editor: get_view_id should return singleton
Because of 9a98a4d60e36ea7d9f29ea52a1524501ebff84de and since the key of an ir.ui.view cannot be unique (multiwebsite), duplicating views made several parts of Odoo crash After this commit, we limit to one the views that are searched with their key Responsibility is given to the user to change the priority and/or the key in order to predict which view will be taken OPW 1913335,1913100,1913186,1913112,1913240 closes odoo/odoo#29105
Diffstat (limited to 'addons')
-rw-r--r--addons/web_editor/models/ir_ui_view.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/addons/web_editor/models/ir_ui_view.py b/addons/web_editor/models/ir_ui_view.py
index 532e3de70d9..45211502f11 100644
--- a/addons/web_editor/models/ir_ui_view.py
+++ b/addons/web_editor/models/ir_ui_view.py
@@ -202,7 +202,7 @@ class IrUiView(models.Model):
@api.model
def _view_obj(self, view_id):
if isinstance(view_id, pycompat.string_types):
- return self.search([('key', '=', view_id)]) or self.env.ref(view_id)
+ return self.search([('key', '=', view_id)], limit=1) or self.env.ref(view_id)
elif isinstance(view_id, pycompat.integer_types):
return self.browse(view_id)
# assume it's already a view object (WTF?)