diff options
| author | Adrien Widart <awt@odoo.com> | 2021-01-14 07:52:59 +0000 |
|---|---|---|
| committer | Arnold Moyaux <arm@odoo.com> | 2021-01-18 10:49:03 +0000 |
| commit | 8dfee8cb2d60942641b73eaa6489b02aa378c5ac (patch) | |
| tree | fa31766fd1efd2aef394c08d08110fb6bdbf61b6 /addons | |
| parent | 2a89c82a1b7e9c60c1e7d79a85899a46d4860bf6 (diff) | |
[FIX] stock: prevent from deleting reserved lines
When using a tracked product in a MO, the lot/serial number reservation
disappears even if the product is still reserved.
To reproduce the error:
(Need mrp)
1. Create two products P and P_compo
- Both are storable
- P_compo is tracked by lots
2. Update P_compo's quantity
- Set the on hand quantity of lot L to 5
3. Create a MO
- Product: P
- Quantity: 5
- Add a line: (Product: P_compo, To Consume: 5)
4. Confirm
5. Check availability
- The P_compo's reserved quantity has been updated to 5. If you
click on the line's details, you can see that 5 P_compo has been
reserved from lot L
6. Back to the MO, in edit mode, change the done quantity: 3/5
- There are still 5 reserved P_compo
7. Click on the P_compo's line details
ERR: the line we saw on step 5 disappeared. The MO says that 5 P_compo
are reserved, but when checking which lot is reserved, the latter is
no more visible. Moreover, if you click on "Confirm" (so you leave the
"Detailed Operations" pop-up), the "Reserved" field of the line will be
reset.
The lot reservation should stay so the user can complete the "Done"
field.
OPW-2420347
closes odoo/odoo#63941
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
Diffstat (limited to 'addons')
| -rw-r--r-- | addons/stock/models/stock_move.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/addons/stock/models/stock_move.py b/addons/stock/models/stock_move.py index c094df3ed7d..7a6a7cc5838 100644 --- a/addons/stock/models/stock_move.py +++ b/addons/stock/models/stock_move.py @@ -490,7 +490,7 @@ class StockMove(models.Model): mls = move.move_line_ids mls = mls.filtered(lambda ml: ml.lot_id) for ml in mls: - if ml.lot_id not in move.lot_ids: + if ml.qty_done and ml.lot_id not in move.lot_ids: move_lines_commands.append((2, ml.id)) ls = move.move_line_ids.lot_id for lot in move.lot_ids: |