diff options
| author | Duc Dao <31387997+novawish@users.noreply.github.com> | 2018-03-13 16:53:32 +0700 |
|---|---|---|
| committer | Adrian Torres <adt@odoo.com> | 2018-03-13 10:53:32 +0100 |
| commit | 66c7e130d570b2711bdd9647a496c1bd76c292eb (patch) | |
| tree | a7a633ef0558183c0f4573378c9c7bef8c8a24ac /addons | |
| parent | 84b6c46943f20b8dc77b390627fbfefa6a181327 (diff) | |
[FIX] base_setup: don't crash if template is empty
Before this commit:
* Activate debug mode.
* Go to general settings > Document Template.
* Change the Template selection to the empty value.
* Click on "Edit Header".
Result: Traceback.
This happens because we try to concatenate the value of the template
field to a string, and since it's empty (False) boolean and str can't be
implicitly concatenated, this of course raises an uncaught error.
After this commit:
* We check if a template has been selected before performing the
concatenation.
Closes #22736
Fixes #22622
Diffstat (limited to 'addons')
| -rw-r--r-- | addons/base_setup/models/res_config_settings.py | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/addons/base_setup/models/res_config_settings.py b/addons/base_setup/models/res_config_settings.py index 32946bf4a59..b5920e47094 100644 --- a/addons/base_setup/models/res_config_settings.py +++ b/addons/base_setup/models/res_config_settings.py @@ -90,6 +90,8 @@ class ResConfigSettings(models.TransientModel): @api.multi def edit_external_header(self): + if not self.external_report_layout: + return False return self._prepare_report_view_action('web.external_layout_' + self.external_report_layout) @api.multi |