[FIX] *: bunch of mismarked translation specifiers

`_(xyz)` will wrap them in an underscore.js object, which when used in
a string context will just return the string. So it's basically a
no-op, but it certainly doesn't translate the terms.

closes odoo/odoo#70000

Related: odoo/enterprise#18001
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

4 files changed, 7 insertions, 6 deletions

diff --git a/addons/point_of_sale/static/src/js/Screens/ClientListScreen/ClientDetailsEdit.js b/addons/point_of_sale/static/src/js/Screens/ClientListScreen/ClientDetailsEdit.js
index 1ac4cf05077..facee796bed 100644
--- a/addons/point_of_sale/static/src/js/Screens/ClientListScreen/ClientDetailsEdit.js
+++ b/addons/point_of_sale/static/src/js/Screens/ClientListScreen/ClientDetailsEdit.js
@@ -1,6 +1,7 @@
 odoo.define('point_of_sale.ClientDetailsEdit', function(require) {
     'use strict';
 
+    const { _t } = require('web.core');
     const { getDataURLFromFile } = require('web.utils');
     const PosComponent = require('point_of_sale.PosComponent');
     const Registries = require('point_of_sale.Registries');
@@ -47,7 +48,7 @@ odoo.define('point_of_sale.ClientDetailsEdit', function(require) {
             if ((!this.props.partner.name && !processedChanges.name) ||
                 processedChanges.name === '' ){
                 return this.showPopup('ErrorPopup', {
-                  title: _('A Customer Name Is Required'),
+                  title: _t('A Customer Name Is Required'),
                 });
             }
             processedChanges.id = this.props.partner.id || false;
diff --git a/addons/pos_adyen/static/src/js/payment_adyen.js b/addons/pos_adyen/static/src/js/payment_adyen.js
index 02a6afdc579..2d53c46146e 100644
--- a/addons/pos_adyen/static/src/js/payment_adyen.js
+++ b/addons/pos_adyen/static/src/js/payment_adyen.js
@@ -38,7 +38,7 @@ var PaymentAdyen = PaymentInterface.extend({
         if (line) {
             line.set_payment_status('retry');
         }
-        this._show_error(_('Could not connect to the Odoo server, please check your internet connection and try again.'));
+        this._show_error(_t('Could not connect to the Odoo server, please check your internet connection and try again.'));
 
         return Promise.reject(data); // prevent subsequent onFullFilled's from being called
     },
@@ -114,7 +114,7 @@ var PaymentAdyen = PaymentInterface.extend({
         var self = this;
 
         if (this.pos.get_order().selected_paymentline.amount < 0) {
-            this._show_error(_('Cannot process transactions with negative amount.'));
+            this._show_error(_t('Cannot process transactions with negative amount.'));
             return Promise.resolve();
         }
 
@@ -150,7 +150,7 @@ var PaymentAdyen = PaymentInterface.extend({
             // Only valid response is a 200 OK HTTP response which is
             // represented by true.
             if (! ignore_error && data !== "ok") {
-                self._show_error(_('Cancelling the payment failed. Please cancel it manually on the payment terminal.'));
+                self._show_error(_t('Cancelling the payment failed. Please cancel it manually on the payment terminal.'));
             }
         });
     },
diff --git a/addons/survey/static/src/js/survey_session_manage.js b/addons/survey/static/src/js/survey_session_manage.js
index 9af7e15d84d..dc9898e718d 100644
--- a/addons/survey/static/src/js/survey_session_manage.js
+++ b/addons/survey/static/src/js/survey_session_manage.js
@@ -330,7 +330,7 @@ publicWidget.registry.SurveySessionManage = publicWidget.Widget.extend({
                 // Display last screen if leaderboard activated
                 self.isLastQuestion = true;
                 self._setupLeaderboard().then(function () {
-                    self.$('.o_survey_session_leaderboard_title').text(_('Final Leaderboard'));
+                    self.$('.o_survey_session_leaderboard_title').text(_t('Final Leaderboard'));
                     self.$('.o_survey_session_navigation_next').addClass('d-none');
                     self.$('.o_survey_leaderboard_buttons').removeClass('d-none');
                     self.leaderBoard.showLeaderboard(false, false);
diff --git a/addons/web/static/src/js/core/ajax.js b/addons/web/static/src/js/core/ajax.js
index a35c793e5c6..29321862d99 100644
--- a/addons/web/static/src/js/core/ajax.js
+++ b/addons/web/static/src/js/core/ajax.js
@@ -311,7 +311,7 @@ function get_file(options) {
     xhr.onerror = function () {
         if (options.error) {
             options.error({
-                message: _("Something happened while trying to contact the server, check that the server is online and that you still have a working network connection."),
+                message: _t("Something happened while trying to contact the server, check that the server is online and that you still have a working network connection."),
                 data: { title: _t("Could not connect to the server") }
             });
         }