[IMP] hr_expense: new tour for user onboarding

Steps:
- In home, expense app icon: "Go to the expense
to attach a receipt"
- In list, on create button : "Click here to create
your first expense and add it to below."
- In form, on save button : "Once your Expense is
ready, you can save it."
- In form, point out the chatter "Attach your
receipt here."
- In list, point out record selection: "Select
expenses to submit them to your manager"
- Point out "Action": "Click on Action Submit To
Manager to submit selected expenses to your manager"
- In expense sheet point out approve “Approve the
sheet here. Tip: if you refuse, don’t forget to
give the reason thanks to the hereunder message
tool".

2 files changed, 36 insertions, 17 deletions

diff --git a/addons/hr_expense/static/src/js/tour.js b/addons/hr_expense/static/src/js/tour.js
index 49cc0c27c26..0e787c421fd 100644
--- a/addons/hr_expense/static/src/js/tour.js
+++ b/addons/hr_expense/static/src/js/tour.js
@@ -6,34 +6,53 @@ var tour = require('web_tour.tour');
 
 var _t = core._t;
 
-tour.register('hr_expense_tour', [{
+tour.register('hr_expense_tour' ,
+{
+    url: "/web"
+},
+[tour.STEPS.MENU_MORE,
+{
     trigger: '.o_app[data-menu-xmlid="hr_expense.menu_hr_expense_root"], .oe_menu_toggler[data-menu-xmlid="hr_expense.menu_hr_expense_root"]',
-    content: _t("Want to manage your employee expenses and receipts? <i>Start here</i>."),
+    content: _t("Go to the expense to attach a receipt."),
     position: 'bottom',
 }, {
-    trigger: 'a#o_mail_test',
-    content: _t("Click to try <b>submitting an expense by email</b>. You can attach a photo of the receipt to the mail."),
-    position: 'right',
+    trigger: '.o_list_button_add',
+    extra_trigger: ".o_expense_tree",
+    content: _t('<p>Click here to create your first expense and add it to below.</p>'),
+    position: 'bottom'
+}, {
+    trigger: ".o_required_modifier input",
+    extra_trigger: ".o_expense_form",
+    content: _t("Write the name of the product, or select an existing one."),
+    position: "top",
 }, {
-    trigger: '.o_expense_submit:visible',
-    content: _t("<p>Once completed, you can <b>submit the expense</b> for approval.</p><p><i>Tip: from the list view, select all expenses to submit them all at once, in a single report.</i></p>"),
-    extra_trigger: '.o_form_readonly',
+    trigger: '.o_form_button_save',
+    extra_trigger: ".o_expense_form",
+    content: _t("<p>Once your Expense is ready, you can save it.</p>"),
     position: 'bottom',
 }, {
-    trigger: '.o_form_button_save:visible',
-    extra_trigger: '.o_expense_sheet',
-    content: _t("Save the report, your manager will receive a notification by email to approve it."),
+    trigger: '.o_expense_form .o_chatter_button_new_message',
+    content: _t("Attach your receipt here."),
+    position: 'top',
+}, {
+    trigger: '.o_expense_tree .o_checkbox > input[type=checkbox]',
+    content: _t('<p>Select expenses to submit them to your manager</p>'),
+    position: 'bottom'
+}, {
+    trigger: '.o_dropdown_toggler_btn',
+    extra_trigger: ".o_expense_tree",
+    content: _t('<p>Click on <b> Action Submit To Manager </b> to submit selected expenses to your manager</p>'),
     position: 'right',
 }, {
-    trigger: '.o_expense_sheet_approve:visible',
-    content: _t("<p>Managers can validate or refuse expense reports.</p><p>If you refuse a report, explain the reason using the <i>New Message</i> button in the bottom.</p>"),
+    trigger: '.o_expense_sheet_approve',
+    content: _t("<p>Approve the sheet here.</p><p>Tip: if you refuse, don’t forget to give the reason thanks to the hereunder message tool</p>"),
     position: 'bottom',
 }, {
-    trigger: '.o_expense_sheet_post:visible',
+    trigger: '.o_expense_sheet_post',
     content: _t("<p>The accountant receive approved expense reports.</p><p>He can post journal entries in one click if taxes and accounts are right.</p>"),
     position: 'bottom',
 }, {
-    trigger: '.o_expense_sheet_pay:visible',
+    trigger: '.o_expense_sheet_pay',
     content: _t("The accountant can register a payment to reimburse the employee directly."),
     position: 'bottom',
 }, {
diff --git a/addons/hr_expense/views/hr_expense_views.xml b/addons/hr_expense/views/hr_expense_views.xml
index dea06f89704..8867044d3c4 100644
--- a/addons/hr_expense/views/hr_expense_views.xml
+++ b/addons/hr_expense/views/hr_expense_views.xml
@@ -5,7 +5,7 @@
             <field name="name">hr.expense.tree</field>
             <field name="model">hr.expense</field>
             <field name="arch" type="xml">
-                <tree string="Expenses" decoration-bf="message_unread == True">
+                <tree string="Expenses" decoration-bf="message_unread == True" class="o_expense_tree">
                     <field name="currency_id" invisible="True"/>
                     <field name="attachment_number" invisible="True"/>
                     <field name="date"/>
@@ -26,7 +26,7 @@
             <field name="model">hr.expense</field>
             <field eval="25" name="priority"/>
             <field name="arch" type="xml">
-                <form string="Expenses">
+                <form string="Expenses" class="o_expense_form">
                 <header>
                     <button name="submit_expenses" states="draft" string="Submit to Manager" type="object" class="oe_highlight o_expense_submit"/>
                     <field name="state" widget="statusbar" statusbar_visible="draft,reported,done"/>