summaryrefslogtreecommitdiff
path: root/addons/website_theme_install/tests/__init__.py
diff options
context:
space:
mode:
authorRomain Derie <rde@odoo.com>2018-12-07 10:38:37 +0000
committerRomain Derie <rde@odoo.com>2018-12-19 18:23:36 +0000
commitf7df35540b8404a14e8d29af80b8e8642a4c1bdb (patch)
tree3863f5d566a5dbdcf01b742cf45b20242d52e1d9 /addons/website_theme_install/tests/__init__.py
parenteb19016ba35d4dc4723edcc244fd412680b5ff2f (diff)
[FIX] web_editor, website(_theme_install): avoid theme.ir.ui.view crash
In a particular case, `_views_get` was mixing apples and oranges, ir.ui.view and theme.ir.ui.view. This was the case if a theme has a theme.ir.ui.view t-calling another theme.ir.ui.view. (Only theme's sale bridge cause this issue, eg theme_kea_sale.products) Then, having that theme installed on a website would make all other website without that theme to crash when opening the /shop customize menu. Indeed, the theme.ir.ui.view would have the xml_id theme_kea_sale.search. The generic view `website_sale.products` would have `theme_kea_sale.products` as inherit child which is website specific and t-call `theme_kea_sale.search`. Then, on a website witout theme_kea installed, opening the customize menu would call `get_related_views` that would call `_views_get` that would loop through inherit children calling `_view_obj` that would not find a view with that key and would fallback on self.env.ref, finding the theme.ir.ui.view. Note: `_views_get` might return specific view for another website but that will be filtered on `get_related_views` override in website. Step to reproduce: - Have at least 2 websites and website_sale installed - Install theme_kea on a website, it will also install theme_kea_sale - Go on the website that has not theme_kea installed - Go to /shop - Open Customize menu, it won't load because of python crash opw-1914576 Closes #29347
Diffstat (limited to 'addons/website_theme_install/tests/__init__.py')
-rw-r--r--addons/website_theme_install/tests/__init__.py4
1 files changed, 4 insertions, 0 deletions
diff --git a/addons/website_theme_install/tests/__init__.py b/addons/website_theme_install/tests/__init__.py
new file mode 100644
index 00000000000..28efb5bbfb5
--- /dev/null
+++ b/addons/website_theme_install/tests/__init__.py
@@ -0,0 +1,4 @@
+# -*- coding: utf-8 -*-
+# Part of Odoo. See LICENSE file for full copyright and licensing details.
+
+from . import test_views