diff options
| author | Julien Castiaux <juc@odoo.com> | 2019-06-11 13:48:23 +0000 |
|---|---|---|
| committer | Julien Castiaux <juc@odoo.com> | 2019-06-17 09:35:37 +0000 |
| commit | cfa1e101e2c98313e6205719bfe34426f39a1b57 (patch) | |
| tree | 526e98577b0725ea426dca099362d0f04239d7ff /addons/website_slides/tests | |
| parent | 38cc2952356d123a03b1a5e248fc0f3668badc30 (diff) | |
[FIX] website_slides: get video id from youtube url
The regexp used to get the youtube video id from its url is broken in
multiple ways.
If the video ID starts with the letter 'v' in the short (youtu.be) url
then the url is considered invalid. i.e. https://youtu.be/vmhB-pt7EfA
If the query option `v=<video id>` is not the first option of the query
in the regular url (youtube.com/watch) then the url is also considered
invalid. i.e. https://www.youtube.com/watch?feature=youtu.be&v=vmhB-pt7EfA
The problem has been solved by replacing the over-engineered regexp by
the dedicated parsing tools of `urllib.parse`.
opw-2006330
closes odoo/odoo#34036
Signed-off-by: Julien Castiaux <Julien00859@users.noreply.github.com>
Diffstat (limited to 'addons/website_slides/tests')
| -rw-r--r-- | addons/website_slides/tests/__init__.py | 1 | ||||
| -rw-r--r-- | addons/website_slides/tests/test_from_url.py | 30 |
2 files changed, 31 insertions, 0 deletions
diff --git a/addons/website_slides/tests/__init__.py b/addons/website_slides/tests/__init__.py new file mode 100644 index 00000000000..801e9234160 --- /dev/null +++ b/addons/website_slides/tests/__init__.py @@ -0,0 +1 @@ +from . import test_from_url
\ No newline at end of file diff --git a/addons/website_slides/tests/test_from_url.py b/addons/website_slides/tests/test_from_url.py new file mode 100644 index 00000000000..dc9a1d6768e --- /dev/null +++ b/addons/website_slides/tests/test_from_url.py @@ -0,0 +1,30 @@ +import odoo.tests + + +class TestFromURL(odoo.tests.TransactionCase): + def test_youtube_urls(self): + urls = { + 'W0JQcpGLSFw': [ + 'https://youtu.be/W0JQcpGLSFw', + 'https://www.youtube.com/watch?v=W0JQcpGLSFw', + 'https://www.youtube.com/watch?v=W0JQcpGLSFw&list=PL1-aSABtP6ACZuppkBqXFgzpNb2nVctZx', + ], + 'vmhB-pt7EfA': [ # id starts with v, it is important + 'https://youtu.be/vmhB-pt7EfA', + 'https://www.youtube.com/watch?feature=youtu.be&v=vmhB-pt7EfA', + 'https://www.youtube.com/watch?v=vmhB-pt7EfA&list=PL1-aSABtP6ACZuppkBqXFgzpNb2nVctZx&index=7', + ], + 'hlhLv0GN1hA': [ + 'https://www.youtube.com/v/hlhLv0GN1hA', + 'https://www.youtube.com/embed/hlhLv0GN1hA', + 'https://m.youtube.com/watch?v=hlhLv0GN1hA' + ], + } + + model = self.env['slide.slide'] + for id, urls in urls.items(): + for url in urls: + with self.subTest(url=url, id=id): + document = model._find_document_data_from_url(url) + self.assertEqual(document[0], 'youtube') + self.assertEqual(document[1], id) |