[REF] {website_}mail: move and replace published field of mail.message to is_internal

PURPOSE

Clean posting process and improve mail.message definition and comprehension.

SPECIFICATIONS

Website mail defines a website_published field allowing to publish / unpublish
comments on the frontend of some modules. This field has several drawbacks :

  * it is used only for front-end people (portal, public) and has no real
    effect in chatter / classic discussions;
  * it is used only in some advanced front-end module and is not available
    in portal by default;
  * its naming is not really correct as it is not linked to fields coming
    from the website_published mixin and its behavior is not really
    the same;
  * its use is a bit duplicated with internal flag coming from subtype
    allowing to hide messages related to an internal subtype;
  * there are overrides of standard mail.message methods just to handle
    this flag;

In this commit we change that field by an is_internal flag directly on
mail.message model itself. It tells if share people (customers, share users)
are allowed to read the message. This field can be given through posting
API or set manually using widgets. It is also used in access rights custom
methods and managed like the internal flag of subtypes.

Mailgateway was already using an internal flag for internal note replies. It
is renamed to is_internal and propagated as it is now a standard field. It
also eases code understanding.

Portal is updated to allow managing the flag directly. It means customer portal
now natively allows to moderate customer comments without any need of website
modules.

Rating is updated accordingly. An is_internal field is added, replacing the
related on website published.

LINKS

Task ID 2071556
PR #38692

1 files changed, 0 insertions, 5 deletions

diff --git a/addons/website_slides/data/slide_user_demo.xml b/addons/website_slides/data/slide_user_demo.xml
index 78cf6138884..95fcc2cbd67 100644
--- a/addons/website_slides/data/slide_user_demo.xml
+++ b/addons/website_slides/data/slide_user_demo.xml
@@ -42,7 +42,6 @@
         <field name="model">slide.channel</field>
         <field name="res_id" ref="website_slides.slide_channel_demo_0_gard_0"/>
         <field name="subtype_id" ref="mail.mt_comment"/>
-        <field name="website_published" eval="True"/>
         <field name="message_type">comment</field>
         <field name="author_id" ref="base.partner_admin"/>
         <field name="body" type="html"><div>I fear beginners could be lost... Isn't it a bit harsh for a "basics" course ?</div></field>
@@ -60,7 +59,6 @@
         <field name="model">slide.channel</field>
         <field name="res_id" ref="website_slides.slide_channel_demo_0_gard_0"/>
         <field name="subtype_id" ref="mail.mt_comment"/>
-        <field name="website_published" eval="True"/>
         <field name="message_type">comment</field>
         <field name="author_id" ref="base.partner_demo"/>
         <field name="body" type="html"><div>Back to basics and interesting. Just WOW !</div></field>
@@ -132,7 +130,6 @@
         <field name="model">slide.channel</field>
         <field name="res_id" ref="website_slides.slide_channel_demo_1_gard1"/>
         <field name="subtype_id" ref="mail.mt_comment"/>
-        <field name="website_published" eval="True"/>
         <field name="message_type">comment</field>
         <field name="author_id" ref="base.partner_admin"/>
         <field name="body" type="html"><div>Very good course.</div></field>
@@ -150,7 +147,6 @@
         <field name="model">slide.channel</field>
         <field name="res_id" ref="website_slides.slide_channel_demo_1_gard1"/>
         <field name="subtype_id" ref="mail.mt_comment"/>
-        <field name="website_published" eval="True"/>
         <field name="message_type">comment</field>
         <field name="author_id" ref="base.partner_demo"/>
         <field name="body" type="html"><div>Interesting !</div></field>
@@ -168,7 +164,6 @@
         <field name="model">slide.channel</field>
         <field name="res_id" ref="website_slides.slide_channel_demo_1_gard1"/>
         <field name="subtype_id" ref="mail.mt_comment"/>
-        <field name="website_published" eval="True"/>
         <field name="message_type">comment</field>
         <field name="author_id" ref="base.partner_demo_portal"/>
         <field name="body" type="html"><div>Interesting. Could be great to include more examples.</div></field>