[IMP] *: correctly read/write website_published

The `website_published` field from the website's mixins is basically a readonly
from `is_published` field.
On read, this field will simply read `is_published` and check if the record's
website_id is accessible (only for the multi mixin).
On write, it will always write on `is_published`.

This commit improves a few things:
- A lot of code was writting on website_published which was just then writting
  on is_published. Writting directly on is_published makes more sense.
- Some backend fields would still reference `website_published` instead of
  `is_published` which would just go through the related for no reason.
  Plus, using `is_published` will make the field tooltip more accurate as we
  are not in a website context ('Visible on current website' to 'Is Published')
- Filter and search on tree view were still using the `website_published`
  related field, which is just a readonly when we are not in a frontend
  context.
- Some create and write function would have security check on
  `website_published` value but that was wrong as the user could bypass that by
  simply writting on `is_published`. For the write method, check `is_published`
  is more accurate as it will cover both case since `website_published` will
  then call the write method on `is_published`

1 files changed, 16 insertions, 16 deletions

diff --git a/addons/website_slides/data/slide_slide_demo.xml b/addons/website_slides/data/slide_slide_demo.xml
index 3e329b38c28..d24b7edce73 100644
--- a/addons/website_slides/data/slide_slide_demo.xml
+++ b/addons/website_slides/data/slide_slide_demo.xml
@@ -11,7 +11,7 @@
         <field name="slide_type">presentation</field>
         <field name="channel_id" ref="website_slides.channel_public"/>
         <field name="category_id" eval="False"/>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="is_preview" eval="True"/>
         <field name="public_views">10</field>
         <field name="completion_time">2.5</field>
@@ -25,7 +25,7 @@
         <field name="slide_type">infographic</field>
         <field name="channel_id" ref="website_slides.channel_public"/>
         <field name="category_id" eval="False"/>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="is_preview" eval="False"/>
         <field name="public_views">5</field>
         <field name="completion_time">1</field>
@@ -42,7 +42,7 @@
         <field name="slide_type">infographic</field>
         <field name="channel_id" ref="website_slides.slide_channel_demo_1_gard1"/>
         <field name="category_id" ref="website_slides.slide_category_demo_1_0"/>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="is_preview" eval="True"/>
         <field name="public_views">5</field>
         <field name="completion_time">0.5</field>
@@ -56,7 +56,7 @@
         <field name="slide_type">infographic</field>
         <field name="channel_id" ref="website_slides.slide_channel_demo_1_gard1"/>
         <field name="category_id" ref="website_slides.slide_category_demo_1_0"/>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="is_preview" eval="False"/>
         <field name="public_views">5</field>
         <field name="completion_time">1.5</field>
@@ -70,7 +70,7 @@
         <field name="slide_type">infographic</field>
         <field name="channel_id" ref="website_slides.slide_channel_demo_1_gard1"/>
         <field name="category_id" ref="website_slides.slide_category_demo_1_0"/>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="is_preview" eval="False"/>
         <field name="public_views">10</field>
         <field name="completion_time">1</field>
@@ -96,7 +96,7 @@
         <field name="slide_type">video</field>
         <field name="channel_id" ref="website_slides.slide_channel_demo_1_gard1"/>
         <field name="category_id" ref="website_slides.slide_category_demo_1_1"/>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="is_preview" eval="False"/>
         <field name="public_views">0</field>
         <field name="completion_time">1</field>
@@ -145,7 +145,7 @@
         </div>
     </div>
 </section></field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="is_preview" eval="True"/>
         <field name="public_views">5</field>
         <field name="completion_time">1</field>
@@ -203,7 +203,7 @@
         <field name="slide_type">presentation</field>
         <field name="channel_id" ref="website_slides.slide_channel_demo_1_gard1"/>
         <field name="category_id" ref="website_slides.slide_category_demo_1_1"/>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="is_preview" eval="False"/>
         <field name="public_views">10</field>
         <field name="completion_time">2.5</field>
@@ -221,7 +221,7 @@
         <field name="slide_type">presentation</field>
         <field name="channel_id" ref="website_slides.slide_channel_demo_2_gard2"/>
         <field name="category_id" ref="website_slides.slide_category_demo_2_0"/>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="is_preview" eval="True"/>
         <field name="public_views">0</field>
         <field name="completion_time">1</field>
@@ -317,7 +317,7 @@
         </div>
     </div>
 </section></field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="is_preview" eval="False"/>
         <field name="public_views">0</field>
         <field name="completion_time">2</field>
@@ -332,7 +332,7 @@
         <field name="slide_type">video</field>
         <field name="channel_id" ref="website_slides.slide_channel_demo_2_gard2"/>
         <field name="category_id" ref="website_slides.slide_category_demo_2_0"/>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="is_preview" eval="False"/>
         <field name="public_views">0</field>
         <field name="completion_time">1</field>
@@ -350,7 +350,7 @@
         <field name="slide_type">presentation</field>
         <field name="channel_id" ref="website_slides.slide_channel_demo_5_furn2"/>
         <field name="category_id" ref="website_slides.slide_category_demo_5_0"/>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="is_preview" eval="True"/>
         <field name="public_views">10</field>
         <field name="completion_time">2.5</field>
@@ -377,7 +377,7 @@
         <field name="channel_id" ref="website_slides.slide_channel_demo_5_furn2"/>
         <field name="category_id" ref="website_slides.slide_category_demo_5_1"/>
         <field name="category_id" eval="False"/>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="is_preview" eval="False"/>
         <field name="public_views">0</field>
         <field name="completion_time">1</field>
@@ -393,7 +393,7 @@
         <field name="channel_id" ref="website_slides.slide_channel_demo_5_furn2"/>
         <field name="category_id" ref="website_slides.slide_category_demo_5_1"/>
         <field name="category_id" eval="False"/>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="is_preview" eval="True"/>
         <field name="public_views">5</field>
         <field name="completion_time">3</field>
@@ -403,10 +403,10 @@
         <field name="name">Test your knowledge !</field>
         <field name="sequence">4</field>
         <field name="image_1920" type="base64" file="website_slides/static/src/img/slide_demo_owl.jpg"/>
-        <field name="slide_type">quiz</field>       
+        <field name="slide_type">quiz</field>
         <field name="channel_id" ref="website_slides.slide_channel_demo_5_furn2"/>
         <field name="category_id" ref="website_slides.slide_category_demo_5_0"/>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="is_preview" eval="False"/>
         <field name="public_views">0</field>
         <field name="completion_time">0.5</field>