[IMP] *: correctly read/write website_published

The `website_published` field from the website's mixins is basically a readonly
from `is_published` field.
On read, this field will simply read `is_published` and check if the record's
website_id is accessible (only for the multi mixin).
On write, it will always write on `is_published`.

This commit improves a few things:
- A lot of code was writting on website_published which was just then writting
  on is_published. Writting directly on is_published makes more sense.
- Some backend fields would still reference `website_published` instead of
  `is_published` which would just go through the related for no reason.
  Plus, using `is_published` will make the field tooltip more accurate as we
  are not in a website context ('Visible on current website' to 'Is Published')
- Filter and search on tree view were still using the `website_published`
  related field, which is just a readonly when we are not in a frontend
  context.
- Some create and write function would have security check on
  `website_published` value but that was wrong as the user could bypass that by
  simply writting on `is_published`. For the write method, check `is_published`
  is more accurate as it will cover both case since `website_published` will
  then call the write method on `is_published`

1 files changed, 4 insertions, 4 deletions

diff --git a/addons/website_sale_slides/data/website_sale_slides_demo.xml b/addons/website_sale_slides/data/website_sale_slides_demo.xml
index f578264c907..57f4857dc6e 100644
--- a/addons/website_sale_slides/data/website_sale_slides_demo.xml
+++ b/addons/website_sale_slides/data/website_sale_slides_demo.xml
@@ -8,7 +8,7 @@
         <field name="standard_price">100.0</field>
         <field name="list_price">100.0</field>
         <field name="type">service</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="image_1920" type="base64" file="website_sale_slides/static/img/product_course.png"/>
     </record>
 
@@ -24,7 +24,7 @@
         <field name="standard_price">12.0</field>
         <field name="list_price">12.0</field>
         <field name="type">consu</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="image_1920" type="base64" file="website_sale_slides/static/img/water_can.jpg"/>
     </record>
 
@@ -33,7 +33,7 @@
         <field name="standard_price">4.5</field>
         <field name="list_price">4.5</field>
         <field name="type">consu</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="image_1920" type="base64" file="website_sale_slides/static/img/flower_pot.jpg"/>
     </record>
 
@@ -42,7 +42,7 @@
         <field name="standard_price">150.0</field>
         <field name="list_price">150.0</field>
         <field name="type">service</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="image_1920" type="base64" file="website_sale_slides/static/img/channel_demo_tree_1.jpg"/>
     </record>