diff options
| author | Romain Derie <rde@odoo.com> | 2019-05-13 17:29:24 +0000 |
|---|---|---|
| committer | Jeremy Kersten <jke@odoo.com> | 2019-08-03 09:51:22 +0000 |
| commit | cc1d78a80b518bd5eaec7eb70d7bc14ec4c31275 (patch) | |
| tree | 9f5dff2b44804e14701e4fe7bc9603086df9af55 /addons/website_membership | |
| parent | f9c2716b3e76ce9bc36d87d69a37a897391c9cdb (diff) | |
[IMP] *: correctly read/write website_published
The `website_published` field from the website's mixins is basically a readonly
from `is_published` field.
On read, this field will simply read `is_published` and check if the record's
website_id is accessible (only for the multi mixin).
On write, it will always write on `is_published`.
This commit improves a few things:
- A lot of code was writting on website_published which was just then writting
on is_published. Writting directly on is_published makes more sense.
- Some backend fields would still reference `website_published` instead of
`is_published` which would just go through the related for no reason.
Plus, using `is_published` will make the field tooltip more accurate as we
are not in a website context ('Visible on current website' to 'Is Published')
- Filter and search on tree view were still using the `website_published`
related field, which is just a readonly when we are not in a frontend
context.
- Some create and write function would have security check on
`website_published` value but that was wrong as the user could bypass that by
simply writting on `is_published`. For the write method, check `is_published`
is more accurate as it will cover both case since `website_published` will
then call the write method on `is_published`
Diffstat (limited to 'addons/website_membership')
| -rw-r--r-- | addons/website_membership/data/membership_demo.xml | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/addons/website_membership/data/membership_demo.xml b/addons/website_membership/data/membership_demo.xml index 395dff2f03b..2aefbc27215 100644 --- a/addons/website_membership/data/membership_demo.xml +++ b/addons/website_membership/data/membership_demo.xml @@ -3,10 +3,10 @@ <data noupdate="1"> <record id="base.res_partner_12" model="res.partner"> - <field name="website_published" eval="True"/> + <field name="is_published" eval="True"/> </record> <record id="base.res_partner_2" model="res.partner"> - <field name="website_published" eval="True"/> + <field name="is_published" eval="True"/> </record> </data> |