diff options
| author | Goffin Simon <sig@odoo.com> | 2020-05-04 10:00:46 +0000 |
|---|---|---|
| committer | Goffin Simon <sig@odoo.com> | 2020-05-06 08:34:59 +0000 |
| commit | 57abcab99b3b33596beb912f5bded0d4b3c28429 (patch) | |
| tree | 59c7089abb65a41eec658bb421c5a7b83efcb9b7 /addons/website_livechat | |
| parent | aa0444e3de8870df5d536517e6a5f870aba2390f (diff) | |
[FIX] im_livechat: Traceback on Safari and Chrome mobile
Steps to reproduce the bug:
- Install website_livechat
- Go to login page on mobile with Safari
- Click on "Have a Question?"
- Close the chat by clicking on the arrow
Bug:
A traceback was raised
Ref:https://stackoverflow.com/questions/19359326/json-parse-fails-in-safari-when-a-string-value-contains-a-comma
opw:2243871
closes odoo/odoo#50715
X-original-commit: 99a5e7c2159f8db3e1ce65f9225f0ce18cc28d70
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Diffstat (limited to 'addons/website_livechat')
| -rw-r--r-- | addons/website_livechat/tests/test_livechat_basic_flow.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/addons/website_livechat/tests/test_livechat_basic_flow.py b/addons/website_livechat/tests/test_livechat_basic_flow.py index 3a03e5db817..ea99c7fff21 100644 --- a/addons/website_livechat/tests/test_livechat_basic_flow.py +++ b/addons/website_livechat/tests/test_livechat_basic_flow.py @@ -41,7 +41,7 @@ class TestLivechatBasicFlowHttpCase(tests.HttpCase, TestLivechatCommon): channel_1 = self.env['mail.channel'].search([('livechat_visitor_id', '=', self.visitor.id), ('livechat_active', '=', True)], limit=1) # Check Channel naming - self.assertEqual(channel_1.name, "%s, %s" % (self.visitor.display_name, self.operator.livechat_username)) + self.assertEqual(channel_1.name, "%s %s" % (self.visitor.display_name, self.operator.livechat_username)) channel_1.unlink() # Remove livechat_username @@ -53,7 +53,7 @@ class TestLivechatBasicFlowHttpCase(tests.HttpCase, TestLivechatCommon): channel_2 = self.env['mail.channel'].search([('livechat_visitor_id', '=', self.visitor.id), ('livechat_active', '=', True)], limit=1) # Check Channel naming - self.assertEqual(channel_2.name, "%s, %s" % (self.visitor.display_name, self.operator.name)) + self.assertEqual(channel_2.name, "%s %s" % (self.visitor.display_name, self.operator.name)) def test_basic_flow_with_rating(self): channel = self._common_basic_flow() @@ -86,7 +86,7 @@ class TestLivechatBasicFlowHttpCase(tests.HttpCase, TestLivechatCommon): # Check Channel and Visitor naming self.assertEqual(self.visitor.display_name, "%s #%s" % (_("Website Visitor"), self.visitor.id)) - self.assertEqual(channel.name, "%s, %s" % (self.visitor.display_name, self.operator.livechat_username)) + self.assertEqual(channel.name, "%s %s" % (self.visitor.display_name, self.operator.livechat_username)) # Post Message from visitor self._send_message(channel, self.visitor.display_name, "Message from Visitor") |