diff options
| author | Romain Derie <rde@odoo.com> | 2019-02-28 14:19:22 +0000 |
|---|---|---|
| committer | Romain Derie <rde@odoo.com> | 2019-03-18 13:54:11 +0000 |
| commit | d0cd971afb518f449ab6c60cef33e6fe0b7ea1f9 (patch) | |
| tree | 8dd47189803e53b5bdee0f3ef86691bcc6c95cab /addons/website_links/views | |
| parent | fd97b5b12a5c0ed9525f11efef98c37a6c302017 (diff) | |
[FIX] website_links: fix remaining bugs and restore skipped test
This commit is following c78da8a80 that fixed website_links module.
We had to merge it with a skipped test as there was an error only appearing
with Docker (on runbot or on local with Docker).
This commit fix that test error and some other remaining bugs not found during
the first fix:
1. Fix the test error by adding a step to show recently used links. Indeed the
bug was that newest links would return inconsistent order as both 2 links
created during the steps have the same creation date.
On runbot it would click on the wrong link, the one which has 0 clicks.
Then JS would crash (see error bellow).
2. `websiteLinksCharts` JS animation class would execute all the `start`
method code even if there was no `_totalClicks`. JS would then crash as
`beginDate` would not be set correctly. Before the refactoring all that code
would be skipped as surrounded by an if/else condition.
3. BS3 to BS4 broke the nav-tabs layout to switch between 'Newest, Most Clicked
and Recently Used. `mt16` needed to be removed.
Closes #31829
Diffstat (limited to 'addons/website_links/views')
| -rw-r--r-- | addons/website_links/views/website_links_template.xml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/addons/website_links/views/website_links_template.xml b/addons/website_links/views/website_links_template.xml index aca362bc40c..626ec232e53 100644 --- a/addons/website_links/views/website_links_template.xml +++ b/addons/website_links/views/website_links_template.xml @@ -87,7 +87,7 @@ </div> <h2 class="o_page_header">Your tracked links - <small class="float-right d-none d-md-block mt16" id="filters"> + <small class="float-right d-none d-md-block" id="filters"> <ul class="nav nav-tabs nav-tabs-inline graph-tabs" role="tablist"> <li class="nav-item"><a aria-controls="filter-newest-links" href="#" class="nav-link active" id="filter-newest-links" role="tab" data-toggle="tab">Newest</a></li> <li class="nav-item"><a aria-controls="filter-most-clicked-links" href="#" class="nav-link" id="filter-most-clicked-links" role="tab" data-toggle="tab">Most Clicked</a></li> |