diff options
| author | Romain Derie <rde@odoo.com> | 2019-02-28 14:19:22 +0000 |
|---|---|---|
| committer | Romain Derie <rde@odoo.com> | 2019-03-11 12:40:32 +0000 |
| commit | c78da8a80d687968bab1dcdff8e48ae904a4d1c2 (patch) | |
| tree | b4146b821b3902c14f86ca2159faaede9241c107 /addons/website_links/static/src/js/website_links.js | |
| parent | 2b3296bbf8b5d08fad20a4ca8d83ebb0aa7303b3 (diff) | |
[FIX] website_links: fix multiple bugs + add tests
Commit 6d67ce5b7c refactored the JS from multiple website modules including
`website_links`.
A few error needed to be fixed:
- recent links would not appear anymore
- graphs would not be displayed anymore
- graph resize on tab change would not be fired
This commit fixes it and also add some tests to be sure this module is now
strongly tested.
Note: tests are skipped for now as there is a race condition happening only
with docker and this fix is getting urgent for Odoo.com
closes odoo/odoo#31507
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Diffstat (limited to 'addons/website_links/static/src/js/website_links.js')
| -rw-r--r-- | addons/website_links/static/src/js/website_links.js | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/addons/website_links/static/src/js/website_links.js b/addons/website_links/static/src/js/website_links.js index f95e1033552..b9754b1bb2c 100644 --- a/addons/website_links/static/src/js/website_links.js +++ b/addons/website_links/static/src/js/website_links.js @@ -8,7 +8,6 @@ var sAnimations = require('website.content.snippets.animation'); var _t = core._t; var SelectBox = Widget.extend({ - xmlDependencies: ['/website_links/static/src/xml/recent_link.xml'], events: { 'change': '_onChange', }, @@ -107,6 +106,7 @@ var SelectBox = Widget.extend({ var RecentLinkBox = Widget.extend({ template: 'website_links.RecentLink', + xmlDependencies: ['/website_links/static/src/xml/recent_link.xml'], events: { 'click .btn_shorten_url_clipboard': '_toggleCopyButton', 'click .o_website_links_edit_code': '_editCode', @@ -460,6 +460,7 @@ sAnimations.registry.websiteLinks = sAnimations.Class.extend({ * @param {Event} ev */ _onFormSubmit: function (ev) { + var self = this; ev.preventDefault(); if ($('#btn_shorten_url').hasClass('btn-copy')) { @@ -511,7 +512,7 @@ sAnimations.registry.websiteLinks = sAnimations.Class.extend({ $('#generated_tracked_link').html(link.short_url); $('#generated_tracked_link').css('display', 'inline'); - this.recentLinks._addLink(link); + self.recentLinks._addLink(link); // Clean URL and UTM selects $('#campaign-select').select2('val', ''); |
