[REF] website_*: review reorganization and enforce conventions

Review the JS reorganization made by direct parent commits and do more
to use our defined JS conventions. Also simplify JS which can be
obviously improved.

2 files changed, 329 insertions, 291 deletions

diff --git a/addons/website_forum/static/src/js/website_forum.js b/addons/website_forum/static/src/js/website_forum.js
index fb7ab69c18c..49865103f7b 100644
--- a/addons/website_forum/static/src/js/website_forum.js
+++ b/addons/website_forum/static/src/js/website_forum.js
@@ -1,63 +1,69 @@
 odoo.define('website_forum.website_forum', function (require) {
 'use strict';
 
-var sAnimations = require('website.content.snippets.animation');
-var ajax = require('web.ajax');
 var core = require('web.core');
+var sAnimations = require('website.content.snippets.animation');
 
 var _t = core._t;
 
-var lastsearch;
-
 sAnimations.registry.websiteForum = sAnimations.Class.extend({
-    selector: '.website_forum',
+    selector: '#wrapwrap:has(.website_forum)',
     read_events: {
-        'click .karma_required': '_onKarmaRequired',
-        'hover .o_js_forum_tag_follow': '_onHoverTagFollowBox',
-        'click .o_forum_profile_pic_edit': '_onEditProfilePic',
-        'change .o_forum_file_upload': '_onChangeFileUpload',
-        'click .o_forum_profile_pic_clear': '_onProfilePicClear',
-        'hover .o_forum_user_info': '_onHoverUserInfo',
-        'hover .o_forum_user_bio_expand': '_onHoverUserBioExpand',
-        'click .flag:not(.karma_required)': '_onFlagAlert',
-        'click .vote_up,.vote_down:not(.karma_required)': '_onVotePost',
-        'click .o_js_validation_queue a[href*="/validate"]': '_onValidationQueue',
-        'click .accept_answer:not(.karma_required)': '_onAcceptAnswer',
-        'click .favourite_question': '_onFavQuestion',
-        'click .comment_delete': '_onDeleteComment',
-        'click .notification_close': '_onCloseNotification',
-        'click .send_validation_email': '_onSendValidationEmail',
-        'click .validated_email_close': '_onCloseValidatedEmail',
-        'click .js_close_intro': '_onCloseIntro',
+        'click .karma_required': '_onKarmaRequiredClick',
+        'mouseenter .o_js_forum_tag_follow': '_onTagFollowBoxMouseEnter',
+        'mouseleave .o_js_forum_tag_follow': '_onTagFollowBoxMouseLeave',
+        'click .o_forum_profile_pic_edit': '_onEditProfilePicClick',
+        'change .o_forum_file_upload': '_onFileUploadChange',
+        'click .o_forum_profile_pic_clear': '_onProfilePicClearClick',
+        'mouseenter .o_forum_user_info': '_onUserInfoMouseEnter',
+        'mouseleave .o_forum_user_info': '_onUserInfoMouseLeave',
+        'mouseleave .o_forum_user_bio_expand': '_onUserBioExpandMouseLeave',
+        'click .flag:not(.karma_required)': '_onFlagAlertClick',
+        'click .vote_up, .vote_down:not(.karma_required)': '_onVotePostClick',
+        'click .o_js_validation_queue a[href*="/validate"]': '_onValidationQueueClick',
+        'click .accept_answer:not(.karma_required)': '_onAcceptAnswerClick',
+        'click .favourite_question': '_onFavoriteQuestionClick',
+        'click .comment_delete': '_onDeleteCommentClick',
+        'click .notification_close': '_onCloseNotificationClick',
+        'click .send_validation_email': '_onSendValidationEmailClick',
+        'click .validated_email_close': '_onCloseValidatedEmailClick',
+        'click .js_close_intro': '_onCloseIntroClick',
         'change .link_url, .o_forum_post_link': '_onCheckPostURL',
     },
 
     /**
      * @override
-     * @param {Object} parent
      */
-    start: function (parent) {
+    start: function () {
+        var self = this;
+
+        this.lastsearch = [];
+
         // float-left class messes up the post layout OPW 769721
         $('span[data-oe-model="forum.post"][data-oe-field="content"]').find('img.float-left').removeClass('float-left');
 
         // welcome message action button
-        var forum_login = _.string.sprintf('%s/web?redirect=%s',
-            window.location.origin, escape(window.location.href));
-        $('.forum_register_url').attr('href',forum_login);
+        var forumLogin = _.string.sprintf('%s/web?redirect=%s',
+            window.location.origin,
+            escape(window.location.href)
+        );
+        $('.forum_register_url').attr('href', forumLogin);
 
         $('input.js_select2').select2({
             tags: true,
-            tokenSeparators: [",", " ", "_"],
+            tokenSeparators: [',', ' ', '_'],
             maximumInputLength: 35,
             minimumInputLength: 2,
             maximumSelectionSize: 5,
             lastsearch: [],
             createSearchChoice: function (term) {
-                if ($(lastsearch).filter(function () { return this.text.localeCompare(term) === 0;}).length === 0) {
+                if (_.filter(self.lastsearch, function (s) {
+                    return s.text.localeCompare(term) === 0;
+                }).length === 0) {
                     //check Karma
-                    if (parseInt($("#karma").val()) >= parseInt($("#karma_edit_retag").val())) {
+                    if (parseInt($('#karma').val()) >= parseInt($('#karma_edit_retag').val())) {
                         return {
-                            id: "_" + $.trim(term),
+                            id: '_' + $.trim(term),
                             text: $.trim(term) + ' *',
                             isNew: true,
                         };
@@ -67,8 +73,7 @@ sAnimations.registry.websiteForum = sAnimations.Class.extend({
             formatResult: function (term) {
                 if (term.isNew) {
                     return '<span class="badge badge-primary">New</span> ' + _.escape(term.text);
-                }
-                else {
+                } else {
                     return _.escape(term.text);
                 }
             },
@@ -78,51 +83,55 @@ sAnimations.registry.websiteForum = sAnimations.Class.extend({
                 data: function (term) {
                     return {
                         q: term,
-                        l: 50
+                        l: 50,
                     };
                 },
                 results: function (data) {
                     var ret = [];
                     _.each(data, function (x) {
-                        ret.push({ id: x.id, text: x.name, isNew: false });
+                        ret.push({
+                            id: x.id,
+                            text: x.name,
+                            isNew: false,
+                        });
                     });
-                    lastsearch = ret;
-                    return { results: ret };
+                    self.lastsearch = ret;
+                    return {results: ret};
                 }
             },
             // Take default tags from the input value
             initSelection: function (element, callback) {
                 var data = [];
                 _.each(element.data('init-value'), function (x) {
-                    data.push({ id: x.id, text: x.name, isNew: false });
+                    data.push({id: x.id, text: x.name, isNew: false});
                 });
                 element.val('');
                 callback(data);
             },
         });
 
-        $('textarea.load_editor').each(function () {
-            var $textarea = $(this);
-            var editor_karma = $textarea.data('karma') || 30;  // default value for backward compatibility
+        _.each($('textarea.load_editor'), function (textarea) {
+            var $textarea = $(textarea);
+            var editorKarma = $textarea.data('karma') || 30;  // default value for backward compatibility
             if (!$textarea.val().match(/\S/)) {
-                $textarea.val("<p><br/></p>");
+                $textarea.val('<p><br/></p>');
             }
             var $form = $textarea.closest('form');
             var toolbar = [
-                    ['style', ['style']],
-                    ['font', ['bold', 'italic', 'underline', 'clear']],
-                    ['para', ['ul', 'ol', 'paragraph']],
-                    ['table', ['table']],
-                    ['history', ['undo', 'redo']],
-                ];
-            if (parseInt($("#karma").val()) >= editor_karma) {
+                ['style', ['style']],
+                ['font', ['bold', 'italic', 'underline', 'clear']],
+                ['para', ['ul', 'ol', 'paragraph']],
+                ['table', ['table']],
+                ['history', ['undo', 'redo']],
+            ];
+            if (parseInt($('#karma').val()) >= editorKarma) {
                 toolbar.push(['insert', ['link', 'picture']]);
             }
             $textarea.summernote({
-                    height: 150,
-                    toolbar: toolbar,
-                    styleWithSpan: false
-                });
+                height: 150,
+                toolbar: toolbar,
+                styleWithSpan: false
+            });
 
             // float-left class messes up the post layout OPW 769721
             $form.find('.note-editable').find('img.float-left').removeClass('float-left');
@@ -132,9 +141,10 @@ sAnimations.registry.websiteForum = sAnimations.Class.extend({
         });
 
         // Check all answer status to add text-success on answer if needed
-        $('.accept_answer').each(function () {
-            if ($(this).hasClass('oe_answer_true')) {
-                $(this).addClass('text-success');
+        _.each($('.accept_answer'), function (el) {
+            var $el = $(el);
+            if ($el.hasClass('oe_answer_true')) {
+                $el.addClass('text-success');
             }
         });
     },
@@ -145,67 +155,73 @@ sAnimations.registry.websiteForum = sAnimations.Class.extend({
 
     /**
      * @private
-     * @param {Object} ev
+     * @param {Event} ev
      */
-    _onKarmaRequired: function (ev) {
-        var karma = $(ev.currentTarget).data('karma');
-        if (karma) {
-            ev.preventDefault();
-            var msg = karma + ' ' + _t(' karma is required to perform this action. You can earn karma by having your answers upvoted by the community.');
-            if ($('a[href*="/login"]').length) {
-                msg = _t('Sorry you must be logged in to perform this action');
-            }
-            var $warning = $('<div class="alert alert-danger alert-dismissable oe_forum_alert mt8" id="karma_alert">'+
-                '<button type="button" class="close notification_close" data-dismiss="alert" aria-hidden="true">&times;</button>'+
-                msg + '</div>');
-            var $voteAlert = $('#karma_alert');
-            if ($voteAlert.length) {
-                $voteAlert.remove();
-            }
-            $(ev.currentTarget).after($warning);
+    _onKarmaRequiredClick: function (ev) {
+        var $karma = $(ev.currentTarget);
+        var karma = $karma.data('karma');
+        if (!karma) {
+            return;
+        }
+        ev.preventDefault();
+        var msg = karma + ' ' + _t("karma is required to perform this action. You can earn karma by having your answers upvoted by the community.");
+        if ($('a[href*="/login"]').length) {
+            msg = _t("Sorry you must be logged in to perform this action");
         }
+        var $warning = $('<div class="alert alert-danger alert-dismissable oe_forum_alert mt8" id="karma_alert">' +
+            '<button type="button" class="close notification_close" data-dismiss="alert" aria-hidden="true">&times;</button>' +
+            msg + '</div>');
+        var $voteAlert = $('#karma_alert');
+        if ($voteAlert.length) {
+            $voteAlert.remove();
+        }
+        $karma.after($warning);
     },
     /**
      * @private
-     * @param {Object} ev
+     * @param {Event} ev
      */
-    _onHoverTagFollowBox: function (ev) {
-        $(function (ev) {
-            $(this).find('.o_forum_tag_follow_box').stop().fadeIn().css('display','block');
-        });
-        $(function (ev) {
-            $(this).find('.o_forum_tag_follow_box').stop().fadeOut().css('display','none');
-        });
+    _onTagFollowBoxMouseEnter: function (ev) {
+        $(ev.currentTarget).find('.o_forum_tag_follow_box').stop().fadeIn().css('display', 'block');
+    },
+    /**
+     * @private
+     * @param {Event} ev
+     */
+    _onTagFollowBoxMouseLeave: function (ev) {
+        $(ev.currentTarget).find('.o_forum_tag_follow_box').stop().fadeOut().css('display', 'none');
     },
     /**
      * @private
-     * @param {Object} ev
+     * @param {Event} ev
      */
-    _onEditProfilePic: function (ev) {
+    _onEditProfilePicClick: function (ev) {
         ev.preventDefault();
-        $(this).closest('form').find('.o_forum_file_upload').trigger('click');
+        $(ev.currentTarget).closest('form').find('.o_forum_file_upload').trigger('click');
     },
     /**
      * @private
-     * @param {Object} ev
+     * @param {Event} ev
      */
-    _onChangeFileUpload: function (ev) {
-        if (this.files.length) {
-            var $form = $(this).closest('form');
-            var reader = new window.FileReader();
-            reader.onload = function (ev) {
-                $form.find('.o_forum_avatar_img').attr('src', ev.target.result);
-            };
-            reader.readAsDataURL(this.files[0]);
-            $form.find('#forum_clear_image').remove();
+    _onFileUploadChange: function (ev) {
+        if (!ev.currentTarget.files.length) {
+            return;
         }
+        var $form = $(ev.currentTarget).closest('form');
+        var reader = new window.FileReader();
+        reader.onload = function (ev) {
+            $form.find('.o_forum_avatar_img').attr('src', ev.target.result);
+        };
+        reader.readAsDataURL(ev.currentTarget.files[0]);
+        $form.find('#forum_clear_image').remove();
     },
     /**
      * @private
+     * @param {Event} ev
      */
-    _onProfilePicClear: function () {
-        var $form = $(this).closest('form');
-        $form.find('.o_forum_avatar_img').attr("src", "/web/static/src/img/placeholder.png");
+    _onProfilePicClearClick: function (ev) {
+        var $form = $(ev.currentTarget).closest('form');
+        $form.find('.o_forum_avatar_img').attr('src', '/web/static/src/img/placeholder.png');
         $form.append($('<input/>', {
             name: 'clear_image',
             id: 'forum_clear_image',
@@ -214,215 +230,229 @@ sAnimations.registry.websiteForum = sAnimations.Class.extend({
     },
     /**
      * @private
+     * @param {Event} ev
      */
-    _onHoverUserInfo: function () {
-        $(function () {
-           $(this).parent().find('.o_forum_user_bio_expand').delay(500).toggle('fast');
-        });
-        $(function () {
-            $(this).parent().find('.o_forum_user_bio_expand').clearQueue();
-        });
+    _onUserInfoMouseEnter: function (ev) {
+        $(ev.currentTarget).parent().find('.o_forum_user_bio_expand').delay(500).toggle('fast');
     },
     /**
      * @private
+     * @param {Event} ev
      */
-    _onHoverUserBioExpand: function () {
-        $(function () {});
-        $(function () {
-            $(this).fadeOut('fast');
-        });
+    _onUserInfoMouseLeave: function (ev) {
+        $(ev.currentTarget).parent().find('.o_forum_user_bio_expand').clearQueue();
+    },
+    /**
+     * @private
+     * @param {Event} ev
+     */
+    _onUserBioExpandMouseLeave: function (ev) {
+        $(ev.currentTarget).fadeOut('fast');
     },
     /**
      * @private
-     * @param {Object} ev
+     * @param {Event} ev
      */
-    _onFlagAlert: function (ev) {
+    _onFlagAlertClick: function (ev) {
         ev.preventDefault();
         var $link = $(ev.currentTarget);
-        ajax.jsonRpc($link.data('href'), 'call', {})
-            .then(function (data) {
-                if (data.error) {
-                    var $warning;
-                    if (data.error === 'anonymous_user') {
-                        $warning = $('<div class="alert alert-danger alert-dismissable oe_forum_alert" id="flag_alert">'+
-                            '<button type="button" class="close notification_close" data-dismiss="alert" aria-hidden="true">&times;</button>'+
-                            _t('Sorry you must be logged to flag a post') +
-                            '</div>');
-                    } else if (data.error === 'post_already_flagged') {
-                        $warning = $('<div class="alert alert-danger alert-dismissable oe_forum_alert" id="flag_alert">'+
-                            '<button type="button" class="close notification_close" data-dismiss="alert" aria-hidden="true">&times;</button>'+
-                            _t('This post is already flagged') +
-                            '</div>');
-                    } else if (data.error === 'post_non_flaggable') {
-                        $warning = $('<div class="alert alert-danger alert-dismissable oe_forum_alert" id="flag_alert">'+
-                            '<button type="button" class="close notification_close" data-dismiss="alert" aria-hidden="true">&times;</button>'+
-                            _t('This post can not be flagged') +
-                            '</div>');
-                    }
-                    var flag_alert = $link.parent().find("#flag_alert");
-                    if (flag_alert.length === 0) {
-                        $link.parent().append($warning);
-                    }
-                } else if (data.success) {
-                    var elem = $link;
-                    if (data.success === 'post_flagged_moderator') {
-                        elem.html(' Flagged');
-                        var c = parseInt($('#count_flagged_posts').html(), 10);
-                        c++;
-                        $('#count_flagged_posts').html(c);
-                    } else if (data.success === 'post_flagged_non_moderator') {
-                        elem.html(' Flagged');
-                        var forum_answer = elem.closest('.forum_answer');
-                        forum_answer.fadeIn(1000);
-                        forum_answer.slideUp(1000);
-                    }
+        this._rpc({
+            route: $link.data('href'),
+        }).then(function (data) {
+            if (data.error) {
+                var $warning;
+                if (data.error === 'anonymous_user') {
+                    $warning = $(
+                        '<div class="alert alert-danger alert-dismissable oe_forum_alert" id="flag_alert">' +
+                            '<button type="button" class="close notification_close" data-dismiss="alert" aria-hidden="true">&times;</button>' +
+                            _t("Sorry you must be logged to flag a post") +
+                        '</div>'
+                    );
+                } else if (data.error === 'post_already_flagged') {
+                    $warning = $(
+                        '<div class="alert alert-danger alert-dismissable oe_forum_alert" id="flag_alert">' +
+                            '<button type="button" class="close notification_close" data-dismiss="alert" aria-hidden="true">&times;</button>' +
+                            _t("This post is already flagged") +
+                        '</div>'
+                    );
+                } else if (data.error === 'post_non_flaggable') {
+                    $warning = $(
+                        '<div class="alert alert-danger alert-dismissable oe_forum_alert" id="flag_alert">' +
+                            '<button type="button" class="close notification_close" data-dismiss="alert" aria-hidden="true">&times;</button>' +
+                            _t("This post can not be flagged") +
+                        '</div>'
+                    );
                 }
-            });
+                var $flagAlert = $link.parent().find('#flag_alert');
+                if ($flagAlert.length === 0) {
+                    $link.parent().append($warning);
+                }
+            } else if (data.success) {
+                var elem = $link;
+                if (data.success === 'post_flagged_moderator') {
+                    elem.html(' Flagged');
+                    var c = parseInt($('#count_flagged_posts').html(), 10);
+                    c++;
+                    $('#count_flagged_posts').html(c);
+                } else if (data.success === 'post_flagged_non_moderator') {
+                    elem.html(' Flagged');
+                    var forumAnswer = elem.closest('.forum_answer');
+                    forumAnswer.fadeIn(1000);
+                    forumAnswer.slideUp(1000);
+                }
+            }
+        });
     },
     /**
      * @private
-     * @param {Object} ev
+     * @param {Event} ev
      */
-    _onVotePost: function (ev) {
+    _onVotePostClick: function (ev) {
         ev.preventDefault();
         var $link = $(ev.currentTarget);
-        ajax.jsonRpc($link.data('href'), 'call', {})
-            .then(function (data) {
-                if (data.error){
-                    var $warning;
-                    if (data.error === 'own_post'){
-                        $warning = $('<div class="alert alert-danger alert-dismissable oe_forum_alert" id="vote_alert">'+
-                            '<button type="button" class="close notification_close" data-dismiss="alert">&times;</button>'+
-                            _t('Sorry, you cannot vote for your own posts') +
-                            '</div>');
-                    } else if (data.error === 'anonymous_user'){
-                        $warning = $('<div class="alert alert-danger alert-dismissable oe_forum_alert" id="vote_alert">'+
-                            '<button type="button" class="close notification_close" data-dismiss="alert">&times;</button>'+
-                            _t('Sorry you must be logged to vote') +
-                            '</div>');
-                    }
-                    var vote_alert = $link.parent().find("#vote_alert");
-                    if (vote_alert.length === 0) {
-                        $link.parent().append($warning);
-                    }
+        this._rpc({
+            route: $link.data('href'),
+        }).then(function (data) {
+            if (data.error) {
+                var $warning;
+                if (data.error === 'own_post') {
+                    $warning = $('<div class="alert alert-danger alert-dismissable oe_forum_alert" id="vote_alert">' +
+                        '<button type="button" class="close notification_close" data-dismiss="alert">&times;</button>' +
+                        _t('Sorry, you cannot vote for your own posts') +
+                        '</div>');
+                } else if (data.error === 'anonymous_user') {
+                    $warning = $('<div class="alert alert-danger alert-dismissable oe_forum_alert" id="vote_alert">' +
+                        '<button type="button" class="close notification_close" data-dismiss="alert">&times;</button>' +
+                        _t('Sorry you must be logged to vote') +
+                        '</div>');
+                }
+                var $voteAlert = $link.parent().find('#vote_alert');
+                if ($voteAlert.length === 0) {
+                    $link.parent().append($warning);
+                }
+            } else {
+                $link.parent().find('.vote_count').html(data['vote_count']);
+                if (data.user_vote === 0) {
+                    $link.parent().find('.text-success').removeClass('text-success');
+                    $link.parent().find('.text-warning').removeClass('text-warning');
                 } else {
-                    $link.parent().find(".vote_count").html(data['vote_count']);
-                    if (data.user_vote === 0) {
-                        $link.parent().find(".text-success").removeClass("text-success");
-                        $link.parent().find(".text-warning").removeClass("text-warning");
+                    if (data.user_vote === 1) {
+                        $link.addClass('text-success');
                     } else {
-                        if (data.user_vote === 1) {
-                            $link.addClass("text-success");
-                        } else {
-                            $link.addClass("text-warning");
-                        }
+                        $link.addClass('text-warning');
                     }
                 }
-            });
+            }
+        });
     },
     /**
      * @private
-     * @param {Object} ev
+     * @param {Event} ev
      */
-    _onValidationQueue: function (ev) {
+    _onValidationQueueClick: function (ev) {
         ev.preventDefault();
         var $link = $(ev.currentTarget);
-        var self = $(this);
-        $(this).parents('.post_to_validate').hide();
-        $.get($link.attr('href'))
-            .fail(function () {
-                self.parents('.o_js_validation_queue > div').addClass('bg-danger text-white').css('background-color', '#FAA');
-                self.parents('.post_to_validate').show();
-            })
-            .done(function () {
-                var left = $('.o_js_validation_queue:visible').length;
-                var type = $('h2.o_page_header a.active').data('type');
-                $('#count_post').text(left);
-                $('#moderation_tools a[href*="/'+type+'_"]').find('strong').text(left);
-            });
+        $link.parents('.post_to_validate').hide();
+        $.get($link.attr('href')).then(function () {
+            var left = $('.o_js_validation_queue:visible').length;
+            var type = $('h2.o_page_header a.active').data('type');
+            $('#count_post').text(left);
+            $('#moderation_tools a[href*="/' + type + '_"]').find('strong').text(left);
+        }, function () {
+            $link.parents('.o_js_validation_queue > div').addClass('bg-danger text-white').css('background-color', '#FAA');
+            $link.parents('.post_to_validate').show();
+        });
     },
     /**
      * @private
-     * @param {Object} ev
+     * @param {Event} ev
      */
-    _onAcceptAnswer: function (ev) {
+    _onAcceptAnswerClick: function (ev) {
         ev.preventDefault();
         var $link = $(ev.currentTarget);
-        ajax.jsonRpc($link.data('href'), 'call', {}).then(function (data) {
+        this._rpc({
+            route: $link.data('href'),
+        }).then(function (data) {
             if (data.error) {
                 if (data.error === 'anonymous_user') {
-                    var $warning = $('<div class="alert alert-danger alert-dismissable" id="correct_answer_alert" style="position:absolute; margin-top: -30px; margin-left: 90px;">'+
-                        '<button type="button" class="close notification_close" data-dismiss="alert" aria-hidden="true">&times;</button>'+
-                        _t('Sorry, anonymous users cannot choose correct answer.') +
-                        '</div>');
+                    var $warning = $(
+                        '<div class="alert alert-danger alert-dismissable" id="correct_answer_alert" style="position:absolute; margin-top: -30px; margin-left: 90px;">' +
+                            '<button type="button" class="close notification_close" data-dismiss="alert" aria-hidden="true">&times;</button>' +
+                            _t("Sorry, anonymous users cannot choose correct answer.") +
+                        '</div>'
+                    );
                 }
-                var correct_answer_alert = $link.parent().find("#correct_answer_alert");
-                if (correct_answer_alert.length === 0) {
+                var $correctAnswerAlert = $link.parent().find('#correct_answer_alert');
+                if ($correctAnswerAlert.length === 0) {
                     $link.parent().append($warning);
                 }
             } else {
-                if (data) {
-                    $link.addClass("oe_answer_true").removeClass('oe_answer_false');
-                } else {
-                    $link.removeClass("oe_answer_true").addClass('oe_answer_false');
-                }
+                $link.toggleClass('oe_answer_true', !!data)
+                     .toggleClass('oe_answer_false', !data);
             }
         });
         this._onCheckAnswerStatus(ev);
     },
     /**
      * @private
-     * @param {Object} ev
+     * @param {Event} ev
      */
     _onCheckAnswerStatus: function (ev) {
         var $link = $(ev.currentTarget);
-        if ($link.hasClass('oe_answer_true')) {
-            $link.removeClass('text-success');
-        } else {
-            $link.addClass('text-success');
-        }
+        $link.toggleClass('text-success', !$link.hasClass('oe_answer_true'));
     },
     /**
      * @private
-     * @param {Object} ev
+     * @param {Event} ev
      */
-    _onFavQuestion: function (ev) {
+    _onFavoriteQuestionClick: function (ev) {
         ev.preventDefault();
         var $link = $(ev.currentTarget);
-        ajax.jsonRpc($link.data('href'), 'call', {}).then(function (data) {
-            $link.toggleClass("forum_favourite_question", !!data);
+        this._rpc({
+            route: $link.data('href'),
+        }).then(function (data) {
+            $link.toggleClass('forum_favourite_question', !!data);
         });
     },
     /**
      * @private
-     * @param {Object} ev
+     * @param {Event} ev
      */
-    _onDeleteComment: function (ev) {
+    _onDeleteCommentClick: function (ev) {
         ev.preventDefault();
         var $link = $(ev.currentTarget);
-        ajax.jsonRpc($link.closest('form').attr('action'), 'call', {}).then(function () {
+        this._rpc({
+            route: $link.closest('form').attr('action'),
+        }).then(function () {
             $link.parents('.comment').first().remove();
         });
     },
     /**
      * @private
-     * @param {Object} ev
+     * @param {Event} ev
      */
-    _onCloseNotification: function (ev) {
+    _onCloseNotificationClick: function (ev) {
         ev.preventDefault();
         var $link = $(ev.currentTarget);
-        ajax.jsonRpc("/forum/notification_read", 'call', {
-            'notification_id': $link.attr("id")});
+        this._rpc({
+            route: '/forum/notification_read',
+            params: {
+                notification_id: $link.attr('id'),
+            },
+        });
     },
     /**
      * @private
-     * @param {Object} ev
+     * @param {Event} ev
      */
-    _onSendValidationEmail: function (ev) {
+    _onSendValidationEmailClick: function (ev) {
         ev.preventDefault();
         var $link = $(ev.currentTarget);
-        ajax.jsonRpc("/forum/send_validation_email", 'call', {
-            'forum_id': $link.attr('forum-id'),
+        this._rpc({
+            route: '/forum/send_validation_email',
+            params: {
+                forum_id: $link.attr('forum-id'),
+            },
         }).then(function (data) {
             if (data) {
                 $('button.validation_email_close').click();
@@ -432,91 +462,98 @@ sAnimations.registry.websiteForum = sAnimations.Class.extend({
     /**
      * @private
      */
-    _onCloseValidatedEmail: function () {
-        ajax.jsonRpc("/forum/validate_email/close", 'call', {});
+    _onCloseValidatedEmailClick: function () {
+        this._rpc({
+            route: '/forum/validate_email/close',
+        });
     },
     /**
      * @private
-     * @param {Object} ev
+     * @param {Event} ev
      */
-    _onCloseIntro: function (ev) {
+    _onCloseIntroClick: function (ev) {
         ev.preventDefault();
-        document.cookie = "forum_welcome_message = false";
+        document.cookie = 'forum_welcome_message = false';
         $('.forum_intro').slideUp();
         return true;
     },
     /**
      * @private
-     * @param {Object} ev
+     * @param {Event} ev
      */
     _onCheckPostURL: function (ev) {
         ev.preventDefault();
         var $link = $(ev.currentTarget);
-        var display_error = function (){
-            var $warning = $('<div class="alert alert-danger alert-dismissable" style="position:absolute; margin-top: -180px; margin-left: 90px;">'+
-                '<button type="button" class="close notification_close" data-dismiss="alert" aria-hidden="true">&times;</button>'+
-                'Please enter valid URL. Example: http://www.odoo.com'+
-                '</div>');
+        var displayError = function () {
+            var $warning = $(
+                '<div class="alert alert-danger alert-dismissable" style="position:absolute; margin-top: -180px; margin-left: 90px;">' +
+                    '<button type="button" class="close notification_close" data-dismiss="alert" aria-hidden="true">&times;</button>' +
+                    _t("Please enter valid URL. Example: http://www.odoo.com") +
+                '</div>'
+            );
             $link.parent().append($warning);
             $link.parents('form').find('button')[0].disabled = true;
         };
         var url = $link.val();
-        if (url.search("^http(s?)://.*")) {
-            url = 'http://'+url;
+        if (url.search('^http(s?)://.*')) {
+            url = 'http://' + url;
         }
 
         // https://gist.github.com/dperini/729294
         var regex = new RegExp(
-          "^" +
+            "^" +
             // protocol identifier
             "(?:(?:https?|ftp)://)" +
             // user:pass authentication
             "(?:\\S+(?::\\S*)?@)?" +
             "(?:" +
-              // IP address exclusion
-              // private & local networks
-              "(?!(?:10|127)(?:\\.\\d{1,3}){3})" +
-              "(?!(?:169\\.254|192\\.168)(?:\\.\\d{1,3}){2})" +
-              "(?!172\\.(?:1[6-9]|2\\d|3[0-1])(?:\\.\\d{1,3}){2})" +
-              // IP address dotted notation octets
-              // excludes loopback network 0.0.0.0
-              // excludes reserved space >= 224.0.0.0
-              // excludes network & broacast addresses
-              // (first & last IP address of each class)
-              "(?:[1-9]\\d?|1\\d\\d|2[01]\\d|22[0-3])" +
-              "(?:\\.(?:1?\\d{1,2}|2[0-4]\\d|25[0-5])){2}" +
-              "(?:\\.(?:[1-9]\\d?|1\\d\\d|2[0-4]\\d|25[0-4]))" +
+            // IP address exclusion
+            // private & local networks
+            "(?!(?:10|127)(?:\\.\\d{1,3}){3})" +
+            "(?!(?:169\\.254|192\\.168)(?:\\.\\d{1,3}){2})" +
+            "(?!172\\.(?:1[6-9]|2\\d|3[0-1])(?:\\.\\d{1,3}){2})" +
+            // IP address dotted notation octets
+            // excludes loopback network 0.0.0.0
+            // excludes reserved space >= 224.0.0.0
+            // excludes network & broacast addresses
+            // (first & last IP address of each class)
+            "(?:[1-9]\\d?|1\\d\\d|2[01]\\d|22[0-3])" +
+            "(?:\\.(?:1?\\d{1,2}|2[0-4]\\d|25[0-5])){2}" +
+            "(?:\\.(?:[1-9]\\d?|1\\d\\d|2[0-4]\\d|25[0-4]))" +
             "|" +
-              // host name
-              "(?:(?:[a-z\\u00a1-\\uffff0-9]-*)*[a-z\\u00a1-\\uffff0-9]+)" +
-              // domain name
-              "(?:\\.(?:[a-z\\u00a1-\\uffff0-9]-*)*[a-z\\u00a1-\\uffff0-9]+)*" +
-              // TLD identifier
-              "(?:\\.(?:[a-z\\u00a1-\\uffff]{2,}))" +
-              // TLD may end with dot
-              "\\.?" +
+            // host name
+            "(?:(?:[a-z\\u00a1-\\uffff0-9]-*)*[a-z\\u00a1-\\uffff0-9]+)" +
+            // domain name
+            "(?:\\.(?:[a-z\\u00a1-\\uffff0-9]-*)*[a-z\\u00a1-\\uffff0-9]+)*" +
+            // TLD identifier
+            "(?:\\.(?:[a-z\\u00a1-\\uffff]{2,}))" +
+            // TLD may end with dot
+            "\\.?" +
             ")" +
             // port number
             "(?::\\d{2,5})?" +
             // resource path
             "(?:[/?#]\\S*)?" +
-          "$", "i"
+            "$", "i"
         );
 
-        if (regex.test(url)){
-            ajax.jsonRpc("/forum/get_url_title", 'call', {'url': url}).then(function (data) {
+        if (regex.test(url)) {
+            this._rpc({
+                route: '/forum/get_url_title',
+                params: {
+                    url: url,
+                },
+            }).then(function (data) {
                 if (data) {
-                    $("input[name='post_name']")[0].value = data;
+                    $('input[name="post_name"]')[0].value = data;
                     $link.parents('form').find('button')[0].disabled = false;
                 } else {
-                    display_error();
+                    displayError();
                 }
-
             });
         } else {
-            display_error();
+            displayError();
         }
     },
 });
-
 });
diff --git a/addons/website_forum/static/src/js/website_forum.share.js b/addons/website_forum/static/src/js/website_forum.share.js
index 8c694304517..9da7059d13f 100644
--- a/addons/website_forum/static/src/js/website_forum.share.js
+++ b/addons/website_forum/static/src/js/website_forum.share.js
@@ -1,19 +1,23 @@
 odoo.define('website_forum.share', function (require) {
 'use strict';
 
-var sAnimations = require('website.content.snippets.animation');
 var core = require('web.core');
+var sAnimations = require('website.content.snippets.animation');
+
 var qweb = core.qweb;
 
+// FIXME There is no reason to inherit from socialShare here
 var ForumShare = sAnimations.registry.socialShare.extend({
+    selector: '',
     xmlDependencies: sAnimations.registry.socialShare.prototype.xmlDependencies
         .concat(['/website_forum/static/src/xml/website_forum_share_templates.xml']),
+    read_events: {},
 
     /**
      * @override
      * @param {Object} parent
-     * @param {Boolean} editableMode
-     * @param {String} targetType
+     * @param {boolean} editableMode
+     * @param {string} targetType
      */
     init: function (parent, editableMode, targetType) {
         this._super.apply(this, arguments);
@@ -21,9 +25,8 @@ var ForumShare = sAnimations.registry.socialShare.extend({
     },
     /**
      * @override
-     * @param {Object} parent
      */
-    start: function (parent) {
+    start: function () {
         var def = this._super.apply(this, arguments);
         this._onMouseEnter();
         return def;
@@ -64,31 +67,31 @@ var ForumShare = sAnimations.registry.socialShare.extend({
             },
         });
     },
-
 });
 
 sAnimations.registry.websiteForumShare = sAnimations.Class.extend({
-    selector: '.website_forum',
+    selector: '#wrapwrap:has(.website_forum)',
     read_events: {
-        'click :not(.karma_required).oe_social_share_call': '_onBody'
+        'click :not(.karma_required).oe_social_share_call': '_onShareCallClick',
     },
 
     /**
      * @override
-     * @param {Object} parent
      */
-    start: function (parent) {
+    start: function () {
         // Retrieve stored social data
         if (sessionStorage.getItem('social_share')) {
             var socialData = JSON.parse(sessionStorage.getItem('social_share'));
-            (new ForumShare(null, false, socialData.targetType)).attachTo($(document.body));
+            (new ForumShare(this, false, socialData.targetType)).attachTo($(document.body));
             sessionStorage.removeItem('social_share');
         }
         // Display an alert if post has no reply and is older than 10 days
         var $questionContainer = $('.oe_js_bump');
         if ($questionContainer.length) {
-            new ForumShare(null, false, 'social-alert').attachTo($questionContainer);
+            new ForumShare(this, false, 'social-alert').attachTo($questionContainer);
         }
+
+        return this._super.apply(this, arguments);
     },
 
     //--------------------------------------------------------------------------
@@ -96,16 +99,14 @@ sAnimations.registry.websiteForumShare = sAnimations.Class.extend({
     //--------------------------------------------------------------------------
 
     /**
-     * Store social share data to display modal on next page
+     * Stores social share data to display modal on next page.
      *
-     * @override
+     * @private
      */
-    _onBody: function () {
+    _onShareCallClick: function (ev) {
         sessionStorage.setItem('social_share', JSON.stringify({
-            targetType: $(this).data('social-target-type'),
+            targetType: $(ev.currentTarget).data('social-target-type'),
         }));
     },
-
 });
-
 });