[IMP] *: use `ref=` instead of `eval="ref('` in xml field tags.

* Code cleanup
* Avoid a safe evaluation of the field value when loading those records.

closes odoo/odoo#44883

Related: odoo/enterprise#8283
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

1 files changed, 25 insertions, 25 deletions

diff --git a/addons/website_forum/data/badges_moderation.xml b/addons/website_forum/data/badges_moderation.xml
index 65dae67a4a3..339029bf400 100644
--- a/addons/website_forum/data/badges_moderation.xml
+++ b/addons/website_forum/data/badges_moderation.xml
@@ -22,11 +22,11 @@
             <field name="description">First downvote</field>
             <field name="computation_mode">count</field>
             <field name="display_mode">boolean</field>
-            <field name="model_id" eval="ref('website_forum.model_forum_post_vote')"/>
+            <field name="model_id" ref="website_forum.model_forum_post_vote"/>
             <field name="condition">higher</field>
             <field name="domain">[('vote', '=', '-1')]</field>
             <field name="batch_mode">True</field>
-            <field name="batch_distinctive_field" eval="ref('website_forum.field_forum_post_vote__user_id')" />
+            <field name="batch_distinctive_field" ref="website_forum.field_forum_post_vote__user_id"/>
             <field name="batch_user_expression">user.id</field>
         </record>
         <record model="gamification.challenge" id="challenge_critic">
@@ -34,15 +34,15 @@
             <field name="period">once</field>
             <field name="visibility_mode">personal</field>
             <field name="report_message_frequency">never</field>
-            <field name="reward_id" eval="ref('badge_5')" />
+            <field name="reward_id" ref="badge_5"/>
             <field name="reward_realtime">True</field>
             <field name="user_domain">[('karma', '>', 0)]</field>
             <field name="state">inprogress</field>
             <field name="challenge_category">forum</field>
         </record>
         <record model="gamification.challenge.line" id="line_critic">
-            <field name="definition_id" eval="ref('definition_critic')"/>
-            <field name="challenge_id" eval="ref('challenge_critic')"/>
+            <field name="definition_id" ref="definition_critic"/>
+            <field name="challenge_id" ref="challenge_critic"/>
             <field name="target_goal">1</field>
         </record>
 
@@ -58,11 +58,11 @@
             <field name="description">Delete own post with 3 or more upvotes</field>
             <field name="computation_mode">count</field>
             <field name="display_mode">boolean</field>
-            <field name="model_id" eval="ref('website_forum.model_forum_post')" />
+            <field name="model_id" ref="website_forum.model_forum_post"/>
             <field name="condition">higher</field>
             <field name="domain">[('vote_count', '>=', 3), ('active', '=', False)]</field>
             <field name="batch_mode">True</field>
-            <field name="batch_distinctive_field" eval="ref('website_forum.field_forum_post__create_uid')" />
+            <field name="batch_distinctive_field" ref="website_forum.field_forum_post__create_uid"/>
             <field name="batch_user_expression">user.id</field>
         </record>
         <record model="gamification.challenge" id="challenge_disciplined">
@@ -70,15 +70,15 @@
             <field name="period">once</field>
             <field name="visibility_mode">personal</field>
             <field name="report_message_frequency">never</field>
-            <field name="reward_id" eval="ref('badge_6')" />
+            <field name="reward_id" ref="badge_6"/>
             <field name="reward_realtime">True</field>
             <field name="user_domain">[('karma', '>', 0)]</field>
             <field name="state">inprogress</field>
             <field name="challenge_category">forum</field>
         </record>
         <record model="gamification.challenge.line" id="line_disciplined">
-            <field name="definition_id" eval="ref('definition_disciplined')"/>
-            <field name="challenge_id" eval="ref('challenge_disciplined')"/>
+            <field name="definition_id" ref="definition_disciplined"/>
+            <field name="challenge_id" ref="challenge_disciplined"/>
             <field name="target_goal">1</field>
         </record>
 
@@ -94,11 +94,11 @@
             <field name="description">First edit of answer or question</field>
             <field name="computation_mode">count</field>
             <field name="display_mode">boolean</field>
-            <field name="model_id" eval="ref('mail.model_mail_message')" />
+            <field name="model_id" ref="mail.model_mail_message"/>
             <field name="condition">higher</field>
             <field name="domain" eval="[('model', '=', 'forum.post'), ('subtype_id', 'in', [ref('website_forum.mt_answer_edit'), ref('website_forum.mt_question_edit')])]"/>
             <field name="batch_mode">True</field>
-            <field name="batch_distinctive_field" eval="ref('mail.field_mail_message__author_id')" />
+            <field name="batch_distinctive_field" ref="mail.field_mail_message__author_id"/>
             <field name="batch_user_expression">user.partner_id.id</field>
         </record>
         <record model="gamification.challenge" id="challenge_editor">
@@ -106,15 +106,15 @@
             <field name="period">once</field>
             <field name="visibility_mode">personal</field>
             <field name="report_message_frequency">never</field>
-            <field name="reward_id" eval="ref('badge_7')" />
+            <field name="reward_id" ref="badge_7"/>
             <field name="reward_realtime">True</field>
             <field name="user_domain">[('karma', '>', 0)]</field>
             <field name="state">inprogress</field>
             <field name="challenge_category">forum</field>
         </record>
         <record model="gamification.challenge.line" id="line_editor">
-            <field name="definition_id" eval="ref('definition_editor')"/>
-            <field name="challenge_id" eval="ref('challenge_editor')"/>
+            <field name="definition_id" ref="definition_editor"/>
+            <field name="challenge_id" ref="challenge_editor"/>
             <field name="target_goal">1</field>
         </record>
 
@@ -129,11 +129,11 @@
             <field name="description">First upvote</field>
             <field name="computation_mode">count</field>
             <field name="display_mode">boolean</field>
-            <field name="model_id" eval="ref('website_forum.model_forum_post_vote')" />
+            <field name="model_id" ref="website_forum.model_forum_post_vote"/>
             <field name="condition">higher</field>
             <field name="domain">[('vote', '=', '1')]</field>
             <field name="batch_mode">True</field>
-            <field name="batch_distinctive_field" eval="ref('website_forum.field_forum_post_vote__user_id')" />
+            <field name="batch_distinctive_field" ref="website_forum.field_forum_post_vote__user_id"/>
             <field name="batch_user_expression">user.id</field>
         </record>
         <record model="gamification.challenge" id="challenge_supporter">
@@ -141,16 +141,16 @@
             <field name="period">once</field>
             <field name="visibility_mode">personal</field>
             <field name="report_message_frequency">never</field>
-            <field name="reward_id" eval="ref('badge_31')" />
+            <field name="reward_id" ref="badge_31"/>
             <field name="reward_realtime">True</field>
             <field name="user_domain">[('karma', '>', 0)]</field>
             <field name="state">inprogress</field>
             <field name="challenge_category">forum</field>
         </record>
         <record model="gamification.challenge.line" id="line_supporter">
-            <field name="definition_id" eval="ref('definition_supporter')" />
+            <field name="definition_id" ref="definition_supporter"/>
             <field name="target_goal">1</field>
-            <field name="challenge_id" eval="ref('challenge_supporter')" />
+            <field name="challenge_id" ref="challenge_supporter"/>
         </record>
 
 
@@ -165,11 +165,11 @@
             <field name="description">Delete own post with 3 or more down votes</field>
             <field name="computation_mode">count</field>
             <field name="display_mode">boolean</field>
-            <field name="model_id" eval="ref('website_forum.model_forum_post')" />
+            <field name="model_id" ref="website_forum.model_forum_post"/>
             <field name="condition">higher</field>
             <field name="domain">[('vote_count', '&lt;=', -3), ('active', '=', False)]</field>
             <field name="batch_mode">True</field>
-            <field name="batch_distinctive_field" eval="ref('website_forum.field_forum_post__create_uid')" />
+            <field name="batch_distinctive_field" ref="website_forum.field_forum_post__create_uid"/>
             <field name="batch_user_expression">user.id</field>
         </record>
         <record model="gamification.challenge" id="challenge_peer_pressure">
@@ -177,16 +177,16 @@
             <field name="period">once</field>
             <field name="visibility_mode">personal</field>
             <field name="report_message_frequency">never</field>
-            <field name="reward_id" eval="ref('badge_23')" />
+            <field name="reward_id" ref="badge_23"/>
             <field name="reward_realtime">True</field>
             <field name="user_domain">[('karma', '>', 0)]</field>
             <field name="state">inprogress</field>
             <field name="challenge_category">forum</field>
         </record>
         <record model="gamification.challenge.line" id="line_peer_pressure">
-            <field name="definition_id" eval="ref('definition_peer_pressure')" />
+            <field name="definition_id" ref="definition_peer_pressure"/>
             <field name="target_goal">1</field>
-            <field name="challenge_id" eval="ref('challenge_peer_pressure')" />
+            <field name="challenge_id" ref="challenge_peer_pressure"/>
         </record>
 
     </data>