[IMP] *: correctly read/write website_published

The `website_published` field from the website's mixins is basically a readonly
from `is_published` field.
On read, this field will simply read `is_published` and check if the record's
website_id is accessible (only for the multi mixin).
On write, it will always write on `is_published`.

This commit improves a few things:
- A lot of code was writting on website_published which was just then writting
  on is_published. Writting directly on is_published makes more sense.
- Some backend fields would still reference `website_published` instead of
  `is_published` which would just go through the related for no reason.
  Plus, using `is_published` will make the field tooltip more accurate as we
  are not in a website context ('Visible on current website' to 'Is Published')
- Filter and search on tree view were still using the `website_published`
  related field, which is just a readonly when we are not in a frontend
  context.
- Some create and write function would have security check on
  `website_published` value but that was wrong as the user could bypass that by
  simply writting on `is_published`. For the write method, check `is_published`
  is more accurate as it will cover both case since `website_published` will
  then call the write method on `is_published`

1 files changed, 30 insertions, 30 deletions

diff --git a/addons/website_event_track/data/event_demo.xml b/addons/website_event_track/data/event_demo.xml
index ce93d170a5a..020c8475959 100644
--- a/addons/website_event_track/data/event_demo.xml
+++ b/addons/website_event_track/data/event_demo.xml
@@ -88,7 +88,7 @@
     </record>
     <record id="event_track1" model="event.track">
         <field name="name">How to design a new piece of furniture</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 06:00:00')"></field>
         <field name="location_id" ref="website_event_track.event_track_location5"/>
@@ -101,7 +101,7 @@
     </record>
     <record id="event_track2" model="event.track">
         <field name="name">How to integrate hardware materials in your pieces of furniture</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 8:30:00')"></field>
         <field name="location_id" ref="website_event_track.event_track_location5"/>
@@ -113,7 +113,7 @@
     </record>
     <record id="event_track3" model="event.track">
         <field name="name">Portfolio presentation</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 10:30:00')"></field>
         <field name="location_id" ref="website_event_track.event_track_location5"/>
@@ -124,7 +124,7 @@
     </record>
     <record id="event_track4" model="event.track">
         <field name="name">How to develop automated processes</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 9:00:00')"></field>
         <field name="location_id" ref="website_event_track.event_track_location5"/>
@@ -135,7 +135,7 @@
     </record>
     <record id="event_track5" model="event.track">
         <field name="name">The new way to promote your creations</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 6:00:00')"></field>
         <field name="location_id" ref="website_event_track.event_track_location6"/>
@@ -146,7 +146,7 @@
     </record>
     <record id="event_track6" model="event.track">
         <field name="name">Detailed roadmap of our new products</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 6:30:00')"></field>
         <field name="location_id" ref="website_event_track.event_track_location6"/>
@@ -157,7 +157,7 @@
     </record>
     <record id="event_track7" model="event.track">
         <field name="name">A technical explanation of how to use computer design apps</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 8:30:00')"></field>
         <field name="location_id" ref="website_event_track.event_track_location6"/>
@@ -168,7 +168,7 @@
     </record>
     <record id="event_track8" model="event.track">
         <field name="name">How to optimize your sales, from leads to sales orders</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 6:00:00')"></field>
         <field name="location_id" ref="website_event_track.event_track_location7"/>
@@ -181,7 +181,7 @@
     </record>
     <record id="event_track9" model="event.track">
         <field name="name">How to improve your quality processes</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="user_id" ref="base.user_admin"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 8:30:00')"></field>
@@ -194,7 +194,7 @@
     </record>
     <record id="event_track10" model="event.track">
         <field name="name">Raising qualitive insights from your customers</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 6:30:00')"></field>
         <field name="location_id" ref="website_event_track.event_track_location7"/>
@@ -205,7 +205,7 @@
     </record>
     <record id="event_track11" model="event.track">
         <field name="name">Discover our new design team</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 10:30:00')"></field>
         <field name="location_id" ref="website_event_track.event_track_location7"/>
@@ -216,7 +216,7 @@
     </record>
     <record id="event_track12" model="event.track">
         <field name="name">Latest trends</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 11:00:00')"></field>
         <field name="location_id" ref="website_event_track.event_track_location7"/>
@@ -227,7 +227,7 @@
     </record>
     <record id="event_track13" model="event.track">
         <field name="name">Advanced reporting</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 6:30:00')"></field>
         <field name="location_id" ref="website_event_track.event_track_location8"/>
@@ -238,7 +238,7 @@
     </record>
     <record id="event_track14" model="event.track">
         <field name="name">Partnership programs</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 7:00:00')"></field>
         <field name="location_id" ref="website_event_track.event_track_location8"/>
@@ -249,7 +249,7 @@
     </record>
     <record id="event_track15" model="event.track">
         <field name="name">How to communicate with your community</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 10:30:00')"></field>
         <field name="location_id" ref="website_event_track.event_track_location8"/>
@@ -260,7 +260,7 @@
     </record>
     <record id="event_track16" model="event.track">
         <field name="name">How to follow us on the social media</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 11:00:00')"></field>
         <field name="location_id" ref="website_event_track.event_track_location8"/>
@@ -271,7 +271,7 @@
     </record>
     <record id="event_track17" model="event.track">
         <field name="name">The new marketing strategy</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 6:00:00')"></field>
         <field name="location_id" ref="website_event_track.event_track_location9"/>
@@ -282,7 +282,7 @@
     </record>
     <record id="event_track18" model="event.track">
         <field name="name">How to build your marketing strategy within a competitive environment</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 8:30:00')"></field>
         <field name="location_id" ref="website_event_track.event_track_location9"/>
@@ -294,7 +294,7 @@
     </record>
     <record id="event_track19" model="event.track">
         <field name="name">Advanced lead management : tips and tricks from the fields</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 9:00:00')"></field>
         <field name="location_id" ref="website_event_track.event_track_location9"/>
@@ -306,7 +306,7 @@
     </record>
     <record id="event_track20" model="event.track">
         <field name="name">New Certification Program</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 10:00:00')"></field>
         <field name="location_id" ref="website_event_track.event_track_location9"/>
@@ -317,7 +317,7 @@
     </record>
     <record id="event_track21" model="event.track">
         <field name="name">House of World Cultures</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 10:30:00')"></field>
         <field name="location_id" ref="website_event_track.event_track_location9"/>
@@ -328,7 +328,7 @@
     </record>
     <record id="event_track22" model="event.track">
         <field name="name">Minimal but efficient design</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 11:00:00')"></field>
         <field name="location_id" ref="website_event_track.event_track_location9"/>
@@ -339,7 +339,7 @@
     </record>
     <record id="event_track23" model="event.track">
         <field name="name">Key Success factors selling our furniture</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 7:00:00')"></field>
         <field name="location_id" ref="website_event_track.event_track_location9"/>
@@ -350,7 +350,7 @@
     </record>
     <record id="event_track24" model="event.track">
         <field name="name">Design contest (entire day)</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 6:00:00')"></field>
         <field name="location_id" ref="website_event_track.event_track_location10"/>
@@ -361,7 +361,7 @@
     </record>
     <record id="event_track25" model="event.track">
         <field name="name">Design contest (entire afternoon)</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 8:30:00')"></field>
         <field name="location_id" ref="website_event_track.event_track_location10"/>
@@ -372,7 +372,7 @@
     </record>
     <record id="event_track27" model="event.track">
         <field name="name">My Company global presentation</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 04:00:00')"></field>
         <field name="duration" eval="1"/>
@@ -383,7 +383,7 @@
     </record>
     <record id="event_track28" model="event.track">
         <field name="name">Status &amp; Strategy</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 5:00:00')"></field>
         <field name="duration" eval="0.5"/>
@@ -393,7 +393,7 @@
     </record>
     <record id="event_track29" model="event.track">
         <field name="name">The new marketing strategy</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 5:30:00')"></field>
         <field name="duration" eval="0.25"/>
@@ -404,7 +404,7 @@
     </record>
     <record id="event_track30" model="event.track">
         <field name="name">Morning break</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 5:45:00')"></field>
         <field name="duration" eval="0.25"/>
@@ -413,7 +413,7 @@
     </record>
     <record id="event_track31" model="event.track">
         <field name="name">Lunch</field>
-        <field name="website_published" eval="True"/>
+        <field name="is_published" eval="True"/>
         <field name="event_id" ref="event.event_0"/>
         <field name="date" eval="time.strftime(str(DateTime.today().year) + '-06-04 7:30:00')"></field>
         <field name="duration" eval="1"/>