[IMP] *: correctly read/write website_published

The `website_published` field from the website's mixins is basically a readonly
from `is_published` field.
On read, this field will simply read `is_published` and check if the record's
website_id is accessible (only for the multi mixin).
On write, it will always write on `is_published`.

This commit improves a few things:
- A lot of code was writting on website_published which was just then writting
  on is_published. Writting directly on is_published makes more sense.
- Some backend fields would still reference `website_published` instead of
  `is_published` which would just go through the related for no reason.
  Plus, using `is_published` will make the field tooltip more accurate as we
  are not in a website context ('Visible on current website' to 'Is Published')
- Filter and search on tree view were still using the `website_published`
  related field, which is just a readonly when we are not in a frontend
  context.
- Some create and write function would have security check on
  `website_published` value but that was wrong as the user could bypass that by
  simply writting on `is_published`. For the write method, check `is_published`
  is more accurate as it will cover both case since `website_published` will
  then call the write method on `is_published`

2 files changed, 6 insertions, 6 deletions

diff --git a/addons/website_customer/data/res_partner_demo.xml b/addons/website_customer/data/res_partner_demo.xml
index 9bea8129a98..3ab130b9091 100644
--- a/addons/website_customer/data/res_partner_demo.xml
+++ b/addons/website_customer/data/res_partner_demo.xml
@@ -3,7 +3,7 @@
     <data noupdate="1">
 
         <record id="base.res_partner_2" model="res.partner">
-            <field name="website_published" eval="True"/>
+            <field name="is_published" eval="True"/>
             <field name="website_short_description">Deco Addict designs, develops, integrates and supports HR and Supply Chain processes in order to make our customers more productive, responsive and profitable.</field>
             <field name="website_description" type="xml">
                 <p>
@@ -33,7 +33,7 @@
             </field>
         </record>
         <record id="base.res_partner_3" model="res.partner">
-            <field name="website_published" eval="True"/>
+            <field name="is_published" eval="True"/>
             <field name="website_short_description">A non-profit international educational and scientific organisation, hosting three departments (aeronautics and aerospace, environmental and applied fluid dynamics, and turbomachinery and propulsion).</field>
             <field name="website_description" type="xml">
                 <p>
@@ -61,7 +61,7 @@
             </field>
         </record>
         <record id="base.res_partner_4" model="res.partner">
-            <field name="website_published" eval="True"/>
+            <field name="is_published" eval="True"/>
             <field name="website_short_description">Deco Addict designs, develops, integrates and supports HR and Supply Chain processes in order to make our customers more productive, responsive and profitable.</field>
             <field name="website_description" type="xml">
                 <p>
@@ -91,7 +91,7 @@
             </field>
         </record>
         <record id="base.res_partner_3" model="res.partner">
-            <field name="website_published" eval="True"/>
+            <field name="is_published" eval="True"/>
             <field name="website_short_description">A non-profit international educational and scientific organisation, hosting three departments (aeronautics and aerospace, environmental and applied fluid dynamics, and turbomachinery and propulsion).</field>
             <field name="website_description" type="xml">
                 <p>
diff --git a/addons/website_customer/views/res_partner_views.xml b/addons/website_customer/views/res_partner_views.xml
index 5c2cf4bec82..e763f00ef8c 100644
--- a/addons/website_customer/views/res_partner_views.xml
+++ b/addons/website_customer/views/res_partner_views.xml
@@ -22,7 +22,7 @@
                     <group col="4">
                         <field name="name"/>
                         <field name="classname"/>
-                        <field name="website_published"/>
+                        <field name="is_published"/>
                         <field name="active"/>
                     </group>
                 </sheet>
@@ -37,7 +37,7 @@
                 <tree string="Website Tags" editable="bottom">
                     <field name="name"/>
                     <field name="classname"/>
-                    <field name="website_published"/>
+                    <field name="is_published"/>
                     <field name="active" invisible="1"/>
                 </tree>
             </field>