diff options
| author | Stéphane Bidoul (ACSONE) <stephane.bidoul@acsone.eu> | 2019-05-10 17:19:55 +0000 |
|---|---|---|
| committer | Thibault Delavallée <tde@odoo.com> | 2019-10-02 15:42:04 +0000 |
| commit | c8c8413e3e86e2abc51ade48f11320de961e5e50 (patch) | |
| tree | 07004cf8d64161b30393ba3f802f346f5d4c29fb /addons/website_blog/models | |
| parent | 9d0f172f29085a6b164313bf20178270b9572cc2 (diff) | |
[IMP] mail: enforce kw args for message_{post/notify/log}
Since there are message_post overrides using the form `def message_post(self,
**kwargs)` in some modules, this method is intended to be invoked with keyword
arguments only.
This commit enforces this behavior. Calls such as `message_post("body")` will
fail regardless of which addon is installed, forcing users to use
`message_post(body="body")`.
It also fixes a message_post override in hr, and applies the same
mechanism to message_notify, and _message_log.
closes odoo/odoo#33306
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Diffstat (limited to 'addons/website_blog/models')
| -rw-r--r-- | addons/website_blog/models/website_blog.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/addons/website_blog/models/website_blog.py b/addons/website_blog/models/website_blog.py index b6e9abbe0ff..47bff0f31aa 100644 --- a/addons/website_blog/models/website_blog.py +++ b/addons/website_blog/models/website_blog.py @@ -37,7 +37,7 @@ class Blog(models.Model): return res @api.returns('mail.message', lambda value: value.id) - def message_post(self, parent_id=False, subtype=None, **kwargs): + def message_post(self, *, parent_id=False, subtype=None, **kwargs): """ Temporary workaround to avoid spam. If someone replies on a channel through the 'Presentation Published' email, it should be considered as a note as we don't want all channel followers to be notified of this answer. """ |