summaryrefslogtreecommitdiff
path: root/addons/website
diff options
context:
space:
mode:
authorAdrian Torres <adt@odoo.com>2017-12-04 14:54:21 +0100
committerChristophe Simonis <chs@odoo.com>2017-12-04 18:49:31 +0100
commit78aef7605c63a2ff0ee7e4a16ebccd7a5ab901b5 (patch)
tree3a61f40c838a0e8d7fba766a668ddcdcd8c03e66 /addons/website
parent8a9973bd2a7b7a7e8e745867fc90079d935aab4b (diff)
[FIX] *: ordered group_by for field with capital letters
When doing a group_by in a tree view, and then ordering by an aggregated field which contains at least one capital letter in its name, you will get an error and won't be able to ordery by this field. Why? read_group is called when sorting a group by, which calls _read_group_raw which then goes to call _read_group_prepare, which will return order by terms in this manner ['id asc', 'x_Test desc'] the problem with this is that postgres automatically converts non-quoted/non-qualified column name to lowercase, of course this means that if we have a field "x_Test" but no field "x_test", it will try to look up "x_test" instead of "x_Test" and since the column doesn't exist, it will throw a ProgrammingError. This commit changes this behavior by wrapping the order_by terms generated in _read_group_prepare with double quotes, which postgres interprets correctly. Fixes #21348 Cherry-Pick of c338e24ee7589c2f4c0d71595262cee58435416b as previous forward-port has been badly done...
Diffstat (limited to 'addons/website')
0 files changed, 0 insertions, 0 deletions