[FIX] website: published/unpublished button + useless code

For some strange reason, two CSS rules had different priorities between
firefox and chrome (which forced chrome to always display published and
unpublished at the same time).

The chosen solution is to change the value of the button in published/
unpublished instead of toggling and relying on CSS classes (with this
method, the DOM looks better too).

There was also duplicated code in website for assets_backend.

1 files changed, 18 insertions, 5 deletions

diff --git a/addons/website/static/src/js/website.backend.js b/addons/website/static/src/js/website.backend.js
index f877c0e90fc..7a3b6a6e580 100644
--- a/addons/website/static/src/js/website.backend.js
+++ b/addons/website/static/src/js/website.backend.js
@@ -3,15 +3,28 @@ odoo.define('website.backend', function (require) {
 
 var core = require('web.core');
 var form_common = require('web.form_common');
-var form_widgets = require('web.form_widgets'); // required to guarantee that
-    // the overrride of fieldtexthtml works
+var form_widgets = require('web.form_widgets'); // required to guarantee
+                                                //  that the overrride of fieldtexthtml works
+var _t = core._t;
 
 var WidgetWebsiteButton = form_common.AbstractField.extend({
     template: 'WidgetWebsiteButton',
     render_value: function() {
-        this._super();
-        this.$el.toggleClass("published", this.get_value() === true);
-        if (this.node.attrs.class) {
+        this._super.apply(this, arguments);
+
+        var $value = this.$('.o_value');
+
+        if(this.get_value() === true) {
+            $value.html(_t('Published'))
+                  .removeClass('text-danger')
+                  .addClass('text-success');
+        } else {
+            $value.html(_t('Not Published'))
+                  .removeClass('text-success')
+                  .addClass('text-danger');
+        }
+
+        if(this.node.attrs.class) {
             this.$el.addClass(this.node.attrs.class);
         }
     },