diff options
| author | qsm-odoo <qsm@odoo.com> | 2020-07-13 14:29:36 +0000 |
|---|---|---|
| committer | qsm-odoo <qsm@odoo.com> | 2020-07-13 15:24:07 +0000 |
| commit | b9ad60d5ebe73ee47eba64145ebe27d483a7f33a (patch) | |
| tree | d60d3664af64b397e28e6b3704c08c750343da4c /addons/website/static/src/js/editor/snippets.editor.js | |
| parent | b558cb7996b1de385f6bf7cb3918f0e37cee69fe (diff) | |
[FIX] web_editor, web: fix traceback with drag & drop when no header
Commit [1] introduced the bug by relying on the fact an element with
id=top is in the edited DOM. As the website header can be disabled, this
induced a crash as soon as the header was indeed disabled. Also, the
editor is not meant to edit the website only so we cannot rely at all
on the presence of a #top element.
[1]: https://github.com/odoo/odoo/commit/6df67a28c2f113572acd4a3db19ab6b1bd37e7da
closes odoo/odoo#54409
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Diffstat (limited to 'addons/website/static/src/js/editor/snippets.editor.js')
| -rw-r--r-- | addons/website/static/src/js/editor/snippets.editor.js | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/addons/website/static/src/js/editor/snippets.editor.js b/addons/website/static/src/js/editor/snippets.editor.js index 04de692f2fd..24b950afc8c 100644 --- a/addons/website/static/src/js/editor/snippets.editor.js +++ b/addons/website/static/src/js/editor/snippets.editor.js @@ -33,6 +33,19 @@ weSnippetEditor.Class.include({ /** * @override */ + _getScrollOptions(options = {}) { + const finalOptions = this._super(...arguments); + if (!options.offsetElements || !options.offsetElements.$top) { + const $header = $('#top'); + if ($header.length) { + finalOptions.offsetElements.$top = $header; + } + } + return finalOptions; + }, + /** + * @override + */ _updateLeftPanelContent: function ({content, tab}) { this._super(...arguments); this.$('.o_we_customize_theme_btn').toggleClass('active', tab === this.tabs.THEME); |
