[IMP] *: correctly read/write website_published

The `website_published` field from the website's mixins is basically a readonly
from `is_published` field.
On read, this field will simply read `is_published` and check if the record's
website_id is accessible (only for the multi mixin).
On write, it will always write on `is_published`.

This commit improves a few things:
- A lot of code was writting on website_published which was just then writting
  on is_published. Writting directly on is_published makes more sense.
- Some backend fields would still reference `website_published` instead of
  `is_published` which would just go through the related for no reason.
  Plus, using `is_published` will make the field tooltip more accurate as we
  are not in a website context ('Visible on current website' to 'Is Published')
- Filter and search on tree view were still using the `website_published`
  related field, which is just a readonly when we are not in a frontend
  context.
- Some create and write function would have security check on
  `website_published` value but that was wrong as the user could bypass that by
  simply writting on `is_published`. For the write method, check `is_published`
  is more accurate as it will cover both case since `website_published` will
  then call the write method on `is_published`

1 files changed, 2 insertions, 2 deletions

diff --git a/addons/website/data/website_demo.xml b/addons/website/data/website_demo.xml
index daa3329fa32..8efebf26764 100644
--- a/addons/website/data/website_demo.xml
+++ b/addons/website/data/website_demo.xml
@@ -303,7 +303,7 @@
         <!-- Showcase all (most?) BS components and utilities -->
         <record id="bs_debug_page" model="website.page">
             <field name="url">/website/demo/bootstrap</field>
-            <field name="website_published">False</field>
+            <field name="is_published">False</field>
             <field name="view_id" ref="bs_debug_view"/>
         </record>
 
@@ -311,7 +311,7 @@
         <!-- Showcase all snippets -->
         <record id="snippets_debug_page" model="website.page">
             <field name="url">/website/demo/snippets</field>
-            <field name="website_published">False</field>
+            <field name="is_published">False</field>
             <field name="view_id" ref="snippets_debug_view"/>
         </record>
     </data>