diff options
| author | rde <rde@odoo.com> | 2017-09-25 15:54:15 +0200 |
|---|---|---|
| committer | rde <rde@odoo.com> | 2017-09-26 16:08:14 +0200 |
| commit | 8baabfb6be9e1db1af0828d705d07a1ec6f0029a (patch) | |
| tree | 15cb01bcd2d445b48d0d0f05aeeff42b422b2599 /addons/website/data/website_data.xml | |
| parent | 0426849de18b587bd0624d644b1208a24edefde9 (diff) | |
[FIX] website_*: convert old ir.ui.view page=True into website.page in 1 record
Before this commit, website.page xml record were created in 2 steps:
1. Create an ir.ui.view record with <template> tag
2. Create a website.page record with <record model="website.page">
But this is useless since website.page inheritS ir.ui.view, you can create both
records just in one <record> tag.
Note: This is NOT TRUE in every case:
Odoo's ORM will suffix external_id of inherited records (in this case the
ir.ui.view created through the website.page record) with its model's name.
This can be a problem in some case (this is an example):
website_crm_template.xml create an ir.ui.view inheriting the
ir.ui.view 'website.contactus'.
But if we didn't keep website.page & ir.ui.view records split for that
specific case, the ir.ui.view would inherit a website.page record
causing an error. (website.contactus would be the id of the page record
while the ir.ui.view's id would be website.contactus_ir_ui_view)
In short: when migrating an ir.ui.view (<record> xml) to a website.page:
* If there is record inheriting the ir.ui.view ID, then split
website.page & ir.ui.view
* if not, you can create the website.page and its ir.ui.view both in one
record (<record model="website.page").
This commit also removed remaining page="True" from xml template since we
removed the 'page' attribute from ir.ui.view model overrided in website module.
Diffstat (limited to 'addons/website/data/website_data.xml')
| -rw-r--r-- | addons/website/data/website_data.xml | 11 |
1 files changed, 1 insertions, 10 deletions
diff --git a/addons/website/data/website_data.xml b/addons/website/data/website_data.xml index a175e02f2c3..1b0de430feb 100644 --- a/addons/website/data/website_data.xml +++ b/addons/website/data/website_data.xml @@ -30,16 +30,7 @@ <field name="website_id" ref="default_website"/> </record> - <!-- - Keep homepage & contactus page split between ir_ui_view & website_page record - So external_id of the ir_ui_view record is still 'website.contactus' and not 'website.contactus_ir_ui_view' (same for homepage) - Indeed Odoo put a suffix on external_id on submodels records (inherits) with the model's name as suffix. - eg: record website_page is 'website.contactus' & ir_ui_view record is 'website.contactus_ir_ui_view' - but since website_crm_template.xml (and surely others) inherit the contactus ir_ui_view record (inherit_id="website.contactus"), - the external_id of the contactus ir_ui_view record still has to be 'website.contactus'. - (Put in another way, external_id 'website.contactus' can't be the external_id of the website_page record or the inherit will ofc fail) - (Or change inherit_id in related files but possibly alot. Safer this way) - --> + <!-- split between ir_ui_view & website_page record to keep external_id on ir_ui_view --> <record id="homepage" model="ir.ui.view"> <field name="name">Home</field> <field name="type">qweb</field> |