[REF] lots of small tweaks to improve the code, and some small fixes, after xmo's code review (addon web_graph)

bzr revid: ged@openerp.com-20140124151635-14l3dchnrmujo5ni

1 files changed, 1 insertions, 4 deletions

diff --git a/addons/web_graph/static/src/js/graph_view.js b/addons/web_graph/static/src/js/graph_view.js
index 1122089f060..e1a50d4ff6d 100644
--- a/addons/web_graph/static/src/js/graph_view.js
+++ b/addons/web_graph/static/src/js/graph_view.js
@@ -39,7 +39,7 @@ instance.web_graph.GraphView = instance.web.View.extend({
         this.widget_config = {
             title: arch.attrs.string,
             stacked : (arch.attrs.stacked === 'True'),
-            mode: (arch.attrs.type) ? arch.attrs.type : 'bar',
+            mode: arch.attrs.type || 'bar',
             measures: [],
             row_groupby: [],
             col_groupby: [],
@@ -181,15 +181,12 @@ instance.web_graph.GraphView = instance.web.View.extend({
             } else {
                 value = {attrs: {domain: [], context: context}};
             }
-            // var value = (category === 'group_by') ? groupby.filter : {attrs:{domain: [], context: context}};
             return {
                 label: groupby.string,
                 value: value
             };
         });
     },
-
-
 });
 };