diff options
| author | Julien Banken <jbn@odoo.com> | 2021-05-10 07:36:51 +0000 |
|---|---|---|
| committer | Julien Banken <jbn@odoo.com> | 2021-05-12 12:32:22 +0000 |
| commit | 9572e2ab46962149372af45efb35b91f6e64f268 (patch) | |
| tree | 4e6d2011643adffe192b95385f259cbe05f485c2 /addons/web_graph/static/lib/dhtmlxGraph/codebase | |
| parent | 5ea2fcbecf572be24af9b2aac76de9e5d5709d2c (diff) | |
[FIX] slides: Verifying the returned value of re.search before accessing the capture groups.
The `search` function of the `re` package can return `None` if the
provided string does not match with the provided pattern
(https://docs.python.org/3/library/re.html#re.Pattern.search).
On the `_parse_youtube_document` function of the `slide.slide` model,
we are directly accessing the capture groups from the returned value
of the `search` function without checking that the returned value is
actually a 'match' object. As a result, an exception can be throw if
there is no match as, in that case, the `search` function will return
`None` and the `group` function will not be defined on `None`.
To avoid throwing an exception, we will check that the returned value
of the `search` function is not `None` before accessing the capture
groups via the `group` function.
LINKS
Task id: 2525007
closes odoo/odoo#70743
X-original-commit: 575a524474fe8866cc71b3befc6bbbde8d73075e
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Diffstat (limited to 'addons/web_graph/static/lib/dhtmlxGraph/codebase')
0 files changed, 0 insertions, 0 deletions
