diff options
| author | kujiu <kujiu@users.noreply.github.com> | 2018-07-04 09:55:52 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-07-04 09:55:52 +0200 |
| commit | f90cf060a3cfeb37a67bec83264c0aaab8892b56 (patch) | |
| tree | fb92375b6d60293cdb49fe2e61fc20bddcd30940 /addons/web_editor | |
| parent | ad0f8fd0b7a468538dfb3bb8c08743913b886e78 (diff) | |
[FIX] Syntax of icons (#25577)
Description of the issue/feature this PR addresses:
Accessibility improvements forbids the use of the syntax
`<i class="fa fa-check"/> Some text`
to create a labelled icon. But, by this, some fonts are changed.
Desired behavior after PR is merged:
The old syntax can be used.
Diffstat (limited to 'addons/web_editor')
| -rw-r--r-- | addons/web_editor/static/src/xml/ace.xml | 2 | ||||
| -rw-r--r-- | addons/web_editor/static/src/xml/editor.xml | 8 | ||||
| -rw-r--r-- | addons/web_editor/static/src/xml/snippets.xml | 2 | ||||
| -rw-r--r-- | addons/web_editor/views/snippets.xml | 2 |
4 files changed, 7 insertions, 7 deletions
diff --git a/addons/web_editor/static/src/xml/ace.xml b/addons/web_editor/static/src/xml/ace.xml index a9cd23cbaaf..de713540a67 100644 --- a/addons/web_editor/static/src/xml/ace.xml +++ b/addons/web_editor/static/src/xml/ace.xml @@ -33,7 +33,7 @@ <div id="ace-view-id"> <span/> <div class="pull-right"> - <button data-action="reset" type="button" class="btn btn-xs btn-danger" icon="fa-undo" string="Reset"></button> + <button data-action="reset" type="button" class="btn btn-xs btn-danger"><i class="fa fa-undo"/> Reset</button> <button data-action="format" type="button" class="btn btn-xs btn-link">Format</button> </div> </div> diff --git a/addons/web_editor/static/src/xml/editor.xml b/addons/web_editor/static/src/xml/editor.xml index 45a16057cd5..7a8827a8ea2 100644 --- a/addons/web_editor/static/src/xml/editor.xml +++ b/addons/web_editor/static/src/xml/editor.xml @@ -9,8 +9,8 @@ <div id="web_editor-top-edit"> <div id="web_editor-toolbars"/> <form class="navbar-form text-muted"> - <button type="button" class="btn btn-sm btn-default fa fa-times" data-action="cancel">Discard</button> - <button type="button" class="btn btn-sm btn-primary fa fa-floppy-o" data-action="save">Save</button> + <button type="button" class="btn btn-sm btn-default" data-action="cancel"><i class="fa fa-times"/> Discard</button> + <button type="button" class="btn btn-sm btn-primary" data-action="save"><i class="fa fa-floppy-o"/> Save</button> </form> </div> </t> @@ -54,10 +54,10 @@ <li class="search pull-right"> <ul class="pager mb0 mt0"> <li class="previous"> - <a role="button" class="btn btn-default disabled" href="#"><span class="fa fa-angle-left"> Previous</span></a> + <a role="button" class="btn btn-default disabled" href="#"><i class="fa fa-angle-left"/> Previous</a> </li> <li class="next"> - <a role="button" class="btn btn-default disabled" href="#"><span class="fa fa-suffix-angle-right">Next </span></a> + <a role="button" class="btn btn-default disabled" href="#">Next <i class="fa fa-angle-right"/></a> </li> </ul> </li> diff --git a/addons/web_editor/static/src/xml/snippets.xml b/addons/web_editor/static/src/xml/snippets.xml index 3eecae059ad..dcd245f9a3e 100644 --- a/addons/web_editor/static/src/xml/snippets.xml +++ b/addons/web_editor/static/src/xml/snippets.xml @@ -40,7 +40,7 @@ <!-- t-field options --> <t t-name="web_editor.many2one.button"> <div class="btn-group"> - <a role="button" href="#" class="btn btn-default btn-sm dropdown-toggle" data-toggle="dropdown" data-hover="dropdown" title="Search Contact" aria-label="Search Contact">><i class="fa fa-search"></i></a> + <a role="button" href="#" class="btn btn-default btn-sm dropdown-toggle" data-toggle="dropdown" data-hover="dropdown" title="Search Contact" aria-label="Search Contact"><i class="fa fa-search"></i></a> <ul class="dropdown-menu contact_menu" role="menu"> <li><a role="menuitem"><input href="#" type="email" placeholder="Search"/></a></li> </ul> diff --git a/addons/web_editor/views/snippets.xml b/addons/web_editor/views/snippets.xml index 6dbd57764ab..096ea58a2ce 100644 --- a/addons/web_editor/views/snippets.xml +++ b/addons/web_editor/views/snippets.xml @@ -6,7 +6,7 @@ <div id="o_scroll"> <div id="snippet_structure" class="o_panel"> <div class="o_panel_header"> - <span class="fa fa-th-large"> First Panel</span> + <i class="fa fa-th-large"/> First Panel </div> <div class="o_panel_body"/> </div> |