diff options
| author | Nicolas Lempereur <nle@odoo.com> | 2016-03-29 17:17:35 +0200 |
|---|---|---|
| committer | Nicolas Lempereur <nle@odoo.com> | 2016-03-30 09:56:23 +0200 |
| commit | b21382bdd149f61dd759c4876cbba7d56a3e1f7b (patch) | |
| tree | 5e7a9e9060363c2a37c24559970eeecd9ef4449f /addons/web_editor/static/src | |
| parent | 109c529c49c79c82c2e5d9a6001bba4f186251d5 (diff) | |
[FIX] web_editor: Cannot read property 'left' of undefined
This issue happen for example on a full runbot when clicking with
shift + key pressed on a sale order not in an editable.
We can see that initial_data.rect is only defined in mousedown when the
click target is inside an editable block, hence it could lead to an
issue otherwise.
closes #11527
Diffstat (limited to 'addons/web_editor/static/src')
| -rw-r--r-- | addons/web_editor/static/src/js/rte.summernote.js | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/addons/web_editor/static/src/js/rte.summernote.js b/addons/web_editor/static/src/js/rte.summernote.js index 65c9df7fce7..8cbb80583b7 100644 --- a/addons/web_editor/static/src/js/rte.summernote.js +++ b/addons/web_editor/static/src/js/rte.summernote.js @@ -566,8 +566,8 @@ function summernote_mouseup (event) { } // don't rerange if simple click if (initial_data.event) { - var dx = event.clientX - (event.shiftKey ? initial_data.rect.left : initial_data.event.clientX); - var dy = event.clientY - (event.shiftKey ? initial_data.rect.top : initial_data.event.clientY); + var dx = event.clientX - (event.shiftKey && initial_data.rect ? initial_data.rect.left : initial_data.event.clientX); + var dy = event.clientY - (event.shiftKey && initial_data.rect ? initial_data.rect.top : initial_data.event.clientY); if (10 < Math.pow(dx, 2)+Math.pow(dy, 2)) { reRangeSelect(event, dx, dy); } |
