[REF] web_editor: code refactoring and simplification

* Remove dead code + optimization
* Use Dialog API from web module
* Reorganize files
* Correct buggy $() function for snippet option class
* Add comments

* Fix the snippet parent navigation :

If a page contained a three level snippet structure (i.e A contains
B contains C), when editing the following bug occured :

If B or C was selected first, parenting buttons were correctly set.
But if selecting A then C, clicking on the parent lead to going back
on A instead of going on B.

* Fix snippet thumbnail layout
* Better isolate ui css from themes
* MediaDialog image list : prevent displaying empty attachments
* ...

2 files changed, 10 insertions, 12 deletions

diff --git a/addons/web_editor/static/src/less/web_editor.ui.components.less b/addons/web_editor/static/src/less/web_editor.ui.components.less
index 6cf994e2f03..d89929bb13d 100644
--- a/addons/web_editor/static/src/less/web_editor.ui.components.less
+++ b/addons/web_editor/static/src/less/web_editor.ui.components.less
@@ -172,6 +172,7 @@ body .modal {
                     &.o_webimage {
                         width: 100%;
                         height: auto;
+                        background-image: none!important;
                     }
                 }
                 &.o_selected .o_image {
@@ -329,11 +330,4 @@ body .modal {
             }
         }
     }
-
-    &.web_editor-dialog {
-        li > label {
-            width: 96%;
-            margin: 4px 2% 0;
-        }
-    }
 }
diff --git a/addons/web_editor/static/src/less/web_editor.ui.less b/addons/web_editor/static/src/less/web_editor.ui.less
index 57caa2dda0e..6cbff90b572 100644
--- a/addons/web_editor/static/src/less/web_editor.ui.less
+++ b/addons/web_editor/static/src/less/web_editor.ui.less
@@ -180,6 +180,10 @@ html[lang] > body.editor_enable{
                         opacity: 0.8;
                     }
                 }
+
+                &:nth-child(2n+1) {
+                    clear: left;
+                }
             }
         }
     }
@@ -495,7 +499,7 @@ html[lang] > body.editor_enable{
                     cursor: e-resize;
                     width: @odoo-handle-edge-size;
                     .o-position-absolute(@o-handles-offset-to-hide, auto, -@o-handles-offset-to-hide, 0);
-                
+
                     &:after {
                         .o-position-absolute(@top: 50%, @left: -@odoo-handle-border-width);
                         margin-top: -@o-handle-size/2;
@@ -506,7 +510,7 @@ html[lang] > body.editor_enable{
                     cursor: w-resize;
                     width: @odoo-handle-edge-size;
                     .o-position-absolute(@o-handles-offset-to-hide, 0, -@o-handles-offset-to-hide, auto);
-                
+
                     &:after {
                         .o-position-absolute(@top: 50%, @right: -@odoo-handle-border-width);
                         margin-top: -@o-handle-size/2;
@@ -657,7 +661,7 @@ html[lang] > body.editor_enable{
     width: auto;
     text-align: center;
     box-shadow: none;
-    
+
     .popover-content {
         height: @odoo-navbar-height;
 
@@ -785,7 +789,7 @@ table.colorpicker {
             padding: 0;
             list-style: none;
             text-align: center;
-            
+
             > li {
                 display: block;
                 float: none;
@@ -944,7 +948,7 @@ body.editor_enable {
         padding-top: @odoo-navbar-height;
         > main {
             height: 100%;
-            #editable_area {  
+            #editable_area {
                 position: relative;
                 overflow: hidden;
                 max-width: 600px;